You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567
#2544's acceptance had two arms. #2562 implements the first, a verdict headline that is not the clean one while the open-findings count reads zero, which wait now reports as its own reading and exits 50 on. Decision #2564 shipped #2562 with that arm only and split the second arm out to this issue.
The second arm is a clean verdict whose headline sentence names outstanding findings, while the open-findings count reads zero and no thread or suppressed block is on the head. scripts/pr_review.py still reports such a round as a clean pass.
Constructed shape:
<!-- ccr-overview-v2 -->### 🟢 Looks good
One minor wording nit remains in the retry helper.
**0 open findings**
Why it was split out
A clean verdict carries no structural marker that it names a finding, so this arm can only be a reading of the headline prose. #2564 records the measurement: across the second-format rounds measured on this repository, roughly a quarter of clean-verdict headlines named a remaining nit while stating no open finding and opening no thread, and nothing in the body says whether that nit is new or an earlier round's thread already answered. #2564 declined a prose heuristic on #2562 for that reason, since it would exit non-zero on most of those rounds and every Copilot wording change would need another reader change.
Done when
A design is chosen that tells a clean-verdict headline naming a new, unthreaded finding apart from one naming an already answered thread, or this arm is closed as not worth a prose reader.
Where a reader is added, a test feeds the constructed shape above, and a test feeds a clean headline that names only an answered thread and still reads clean.
Maintainer decision, 2026-10-18: print it, do not gate. When a clean-verdict round's headline sentence names a finding while it states no open finding and opens no thread or suppressed block, pr_review.py shows that sentence as an advisory line in the digest and keeps exit 0. It adds no exit code and does not try to tell a new nit from one already answered. A test feeds the constructed shape above and asserts that the headline is printed and the exit stays clean.
Activity
Promote develop to main: Read Copilot's Overview Sections Through One…
ptr727 commentedon Oct 19, 2026
Maintainer decision, 2026-10-18: print it, do not gate. When a clean-verdict round's headline sentence names a finding while it states no open finding and opens no thread or suppressed block,
pr_review.pyshows that sentence as an advisory line in the digest and keeps exit0. It adds no exit code and does not try to tell a new nit from one already answered. A test feeds the constructed shape above and asserts that the headline is printed and the exit stays clean.Print a Clean Verdict's Headline as an Advisory Line in pr_review.py (#…
Promote the Clean Headline Advisory and hub_fetch_run.py Rename to Ma…