Skip to content

pr_review.py Passes a Copilot Round Whose Headline Names Findings Beside a Zero Open-Findings Count #2544

Closed

Description

@ptr727

Problem

scripts/pr_review.py reads a Copilot ccr-overview-v2 review whose verdict headline names findings that no thread, no suppressed block and no open-findings count carries, and it reports the round as clean.

Constructed shape (the real one appeared on #2542):

<!-- ccr-overview-v2 -->

### 🔵 Needs a closer look

Resolve the two outstanding parser-retry and timeout-handling findings.

**0 open findings**

The digest for that round read threads=0 unresolved=0 suppressed=0 overview=0/0 shapes=ok, and wait exited 0. The headline is the one place the two findings exist, so a loop that trusts the digest merges over them. #2542 caught this only because the review body was read by hand, per the Merge Gate's "the matched review is read, not just counted".

This is a sibling of #2480, which covers the collapsible N open findings block. The class is the same, findings named in an overview section the reader does not parse, but the shape differs: here the count line says zero and the headline names findings.

Done when

  • A round whose verdict headline is not the clean one, or whose headline sentence names outstanding findings, while open findings reads zero and no thread or suppressed block is on the head, is reported as its own reading rather than as a clean pass, and wait exits non-zero on it.
  • A test feeds the constructed shape above.

Activity

  1. added
    bugSomething isn't working
    scriptA defect in hub tooling
    on Oct 8, 2026
  2. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Folded into the auto-2480 lane (#2547) by the maintainer, 2026-10-08, so one recognizer covers every Copilot overview section, per #2516's one-primitive-per-class rule. The windows lane no longer works this issue.

  3. added a commit that references this issue on Oct 8, 2026
    763bf47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingscriptA defect in hub tooling

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions