Skip to content

Session Handoff [auto-2480]: Read Copilot's Collapsible Overview Blocks per #2480 #2547

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480: teach scripts/pr_review.py to read Copilot's collapsible <summary><strong>N open findings</strong></summary> overview block, and, per the fold recorded on Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480, the "Resolved Since Last Review" block from Recognize Copilot's "Resolved Since Last Review" Overview Block in pr_review.py #2479, through one recognizer with a test for each shape built from constructed text. The pull request body carries Closes on promotion: #2480, #2479. Done looks like pr_review.py wait reading a review carrying either block without exiting 43.

External blockers

None.

Internal dependencies

Decisions #2533, #2540, and #2546 each came from this block going unread, so this fix is what stops later lanes parking on it. Do not answer those decisions here.

State

No branch or pull request yet. Re-derive from git and GitHub.

The parked decision queue

Not applicable to this lane.

What the last round did

Queued from the unattended run after three rounds parked on this one cause.

What not to repeat

Do not add a per-shape special case beside the existing readers. #2516's rule applies: one recognizer for the block class.

New learnings

None.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 8, 2026
  2. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Scope widened by the maintainer, 2026-10-08, from the windows lane: #2544 folds into this lane's one-recognizer fix. #2544 is the same class, a Copilot ccr-overview-v2 section the reader does not parse, where the verdict headline names findings beside **0 open findings**. The recognizer should report that headline as its own reading, not as a clean pass. Add a test for the constructed shape in #2544, and add #2544 to the pull request's Closes on promotion line.

  3. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Parked, waiting on decision #2564

    Done. #2562, from feature/auto-2480 into develop, is open and pushed at dc1de527. Its changes:

    • One recognizer, read_overview in scripts/pr_review.py, reads the second overview format. It covers the verdict and headline, the count-first open-findings section in both numbers, both resolved spellings, and Open (N). The rows live in one table, OVERVIEW_SECTIONS.
    • Open-section entries are matched against threads by fullDatabaseId.
    • A flagging verdict that counts no finding exits 50.
    • scripts/README.md, the module docstring, and pr-review-conduct are updated, and the generated skills are rebuilt.

    The pull request closes on promotion #2480, #2479, #2544, and #1723. #1723 is included, because its three shapes were already vetted and this change gives Open (N) its reader. #2481 is not included and is left to its own lane. It would change what overview=T/M means across the docstring, the README, and the skill, which is past one recognizer.

    Review state.

    • Nine local strict-review passes ran, and the last one, over dc1de527, recorded 0 findings.
    • Copilot reviewed twice. All 5 threads were fixed, replied to, and resolved.
    • The head is covered by an attested local pass (review_on_head=local). When this lane parked, checks were still running (6 of 10).
    • The branch's own pr_review.py reads every round as shapes=ok. Develop's copy still exits 43 on the (N) open finding(s) summaries, which are the shapes this pull request fixes.

    Why it parked. Copilot's second round has the headline "Two moderate issues remain in unlinked-entry counting and clean-verdict headline detection." Its one open finding was the first issue, which is now fixed. The second issue names #2544's headline-sentence arm, which #2562 deliberately does not implement. Leaving an acceptance arm out is a value call, so it is decision #2564. That issue sets out the options and a recommendation.

    What remains.

    1. Answer Ship the Exit-50 Verdict Reading Without #2544's Headline-Sentence Arm? #2564.
    2. Under option 1 or 3, answer the headline item on Read Copilot's Overview Sections Through One Recognizer in pr_review.py #2562 with pr_review.py comment, citing Ship the Exit-50 Verdict Reading Without #2544's Headline-Sentence Arm? #2564. Then confirm that checks are green and squash-merge to develop. This run's scope is main, so the develop to main promotion follows.
    3. Under option 2, add the prose arm on the branch and run the review loop again.

    Worktree. /home/pieter/repos/worktrees/ProjectTemplate-auto-2480 is clean and is left standing on feature/auto-2480.

    Lessons. None filed.

  4. added
    blockedBlocked on another issue: one in another repository, or a decision issue here for a parked handoff
    on Oct 8, 2026
  5. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Continued in #2565, round 2 on track auto-2480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedBlocked on another issue: one in another repository, or a decision issue here for a parked handoffhandoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions