Skip to content

Session Handoff [auto-1862]: Empty PATH Fallback in Three Test Harnesses (#1862) #2715

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix Three Test Harnesses Build a Stand-In PATH With an Empty Fallback When PATH Is Unset #1862. The harnesses the issue names moved from scripts/tests/ to tests/, and their line numbers moved with them, so locate each site by its code rather than by the issue's line numbers. On develop at pick time they are the stub-directory prepend in tests/test_local_review.py that builds PATH from os.environ.get("PATH", ""), and the two child environments in tests/test_skills_install.py that pass {"PATH": os.environ.get("PATH", ""), ...}. Move each to the os.defpath fallback the earlier fixes used, os.environ.get("PATH", os.defpath), as tests/test_configure_archived.py and tests/test_configure_usage.py already do. The issue asks for each site to be read on its own: the test_local_review.py sites that deliberately set PATH to an empty directory and restore the previous value are a different shape and may be correct as they are, so judge each and state the judgment in the pull request body. Verify with env -u PATH /usr/bin/python3 -m unittest <module> against the same run with PATH set, before and after the change. Done looks like a pull request into develop carrying Closes on promotion: #1862, driven and merged as far as the run's scope allows.

External blockers

None known at pick time.

Internal dependencies

None. The lane holds one issue.

State

No branch, worktree, or pull request exists for this lane yet. Re-derive the sites and develop's state at resume rather than trusting the description above.

The parked decision queue

None. The picker judged #1862 auto-resolvable: its outcome is the fallback the earlier fixes already applied, and the one site it leaves to judgment is a reading the issue asks the fixer to make rather than a choice between alternatives.

What the last round did

The unattended-handoff picker created this lane for #1862.

What not to repeat

Nothing yet.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 10, 2026
  2. ptr727 commented on Oct 10, 2026

    @ptr727
    OwnerAuthor

    Done. PR #2716 merged to develop (e372d7b), fixing #1862 (closes on promotion). Two sites moved to the os.defpath fallback: the fake_cli PATH prepend in tests/test_local_review.py (cleanup now restores unset correctly) and both child envs in tests/test_skills_install.py. The deliberate empty-directory PATH test was judged correct as is. test_skills_install now passes with PATH unset. test_local_review still errors under unset PATH in its setUp (bare git subprocess), outside the three sites and failing before. The remote branch feature/auto-1862 was not deleted (the delete was refused by the executor); it matches the merged head and is safe to remove. Nothing filed. Closing the lane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions