Repository navigation
Fall Back to os.defpath for PATH in Two Test Harnesses - #2716
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Updates two test harnesses to preserve the platform default PATH when the environment variable is unset.
Changes:
- Uses
os.defpathfor child process environments. - Restores an originally unset
PATHcorrectly during cleanup.
| File | Summary |
|---|---|
tests/test_skills_install.py |
Preserves the default PATH in subprocess tests. |
tests/test_local_review.py |
Preserves default lookup and restores unset PATH correctly. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2716 +/- ##
==========================================
Coverage ? 59.67%
==========================================
Files ? 16
Lines ? 8334
Branches ? 0
==========================================
Hits ? 4973
Misses ? 3361
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 10, 2026
ptr727
added a commit
that referenced
this pull request
Oct 10, 2026
… Corrections to Main (#2740) ## Summary Promotes 20 changes from `develop` to `main`: - #2737: Flag a Lone Semicolon After an Explanatory Colon in the Prose Gate - #2734: Share pr_review.py wait's Liveness Readings and Open the Held Poll on Its Snapshot - #2732: Share One Bounded Backoff Loop Between pr_review.py wait's Two Polls - #2729: Document pr_review.py wait's Immediate 44 and check_nodes's Node Keys - #2727: Narrow pr_review.py wait's Exit 44 to Required Checks - #2722: Poll an Attested Head's Checks in pr_review.py wait - #2720: Name the Command That Enumerates Open Feature Pull Requests in backlog-burndown - #2718: Point the Skills Refresh Cadence at host-setup.md - #2716: Fall Back to os.defpath for PATH in Two Test Harnesses - #2714: State the Pip Form's Root-Config Type-Check Command in python-codestyle - #2712: State the Build Profile's CI Type Check as the Validator Runs It - #2709: Bring the Fleet-Map workflow-ci-contract Entry and G9 Gap Up to the Skill Description - #2707: Bring the Line-Endings Reference and a Test Docstring to the Corrected Wording - #2705: Drop the Stale Utilities driftNote From the Registry - #2703: Remove the Inert SC2016 Directives in configure.sh and Correct the shell-codestyle Claim - #2701: Report Whether the Fleet Skills Plugin Is Installed and Enabled in the Live Channel - #2699: Align the Audit Report Template Dimensions With AUDIT.md Section 4 - #2697: Harden the Source-Pinning Assertions in test_pr_review.py - #2695: Name the Off-Grammar --branch Outcome in AUDIT.md - #2693: Count Every Unresolved Review Thread in pr_review.py Closes #1396 Closes #2731 Closes #2723 Closes #2725 Closes #2724 Closes #2685 Closes #1308 Closes #2191 Closes #1862 Closes #2711 Closes #2025 Closes #1243 Closes #1237 Closes #1115 Closes #1156 Closes #1757 Closes #1593 Closes #1732 Closes #1509 Closes #1404 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test harnesses built a child's PATH from an empty fallback, so with PATH unset the child lost the default search path that the parent's lookup used.
tests/test_skills_install.py: both child environments now useos.environ.get("PATH", os.defpath).tests/test_local_review.pyfake_cli: the stub directory is prepended toos.defpathwhen PATH is unset, and the cleanup now restores the true previous state (unset is popped, not set to empty).tests/test_local_review.pytest_a_missing_binary_is_a_boundary_through_main: judged correct as is. It deliberately replaces PATH with an empty directory, so no fallback applies.Verification with
env -u PATH /usr/bin/python3 -m unittest test_skills_install: before, 1 failure and 4 errors; after, OK.test_local_reviewunder unset PATH still errors in setUp where it runs baregit(outside the three sites; 105 failing before, 102 after). With PATH set both modules pass.Closes on promotion: #1862
🤖 Generated with Claude Code