Repository navigation
Read pr_review.py's state= Field in drive-pr and Document It in scripts/README.md #3688
Description
Problem
scripts/pr_review.py status and wait now carry state=MERGED or state=CLOSED in the digest when a pull request is no longer open (#3677). wait on such a pull request neither requests nor polls, and exits as status does, so its 0 there says nothing about review coverage. drive-pr reads only wait's exit codes (49 and 46 specially) and does not read state=. So a feature pull request closed while it was being driven goes on to the merge step, where gh pr merge fails loudly rather than the drive stopping and reporting the state on its first read.
scripts/README.md's pr_review.py section also does not yet mention the state=, merged_at=, merge_commit=, and closed_at= fields, or wait's handling of a pull request that is no longer open.
Reproduce
- Close an unmerged feature pull request with no attestation.
- Run
uv run --no-project --script scripts/pr_review.py wait <n> --repo OWNER/NAME. - It exits
0withstate=CLOSEDin the digest, whichdrive-prreads as "go on".
Done when
drive-prstops and reports on a digest carryingstate=, naming the state, before any merge step.scripts/README.mddocuments the fields andwait's behavior on a pull request that is no longer open.
Activity
Read a Null GraphQL Node as Unread and Name a Closed Pull Request's S…
ptr727 commentedon Oct 31, 2026
Backlog burndown round 2 claim. Branch:
feature/burndown-3688. Group: #3688.Predicted file set:
.agents/skills/drive-pr/SKILL.mdand its generated copies.github/skills/drive-pr/SKILL.mdand.claude-plugin/fleet-skills/skills/drive-pr/SKILL.mdscripts/README.mdNo other live group may edit these files until this branch merges or the claim is released here.
ptr727 commentedon Oct 31, 2026
Claim update for
feature/burndown-3688: the file set gains.claude-plugin/fleet-skills/.source-digests/drive-pr, the per-skill source digestscripts/build_dist.pyregenerates with thedrive-prcopies. No other group holds it.Stop drive-pr on a Pull Request No Longer Open and Document pr_review…
ptr727 commentedon Oct 31, 2026
Claim released:
feature/burndown-3688merged todevelopas #3698 and its branch and worktree are cleaned up.scripts/README.mdpasses tofeature/burndown-3672-3489. This issue closes when the nextdevelop->mainpromotion merges.