Repository navigation
Stop drive-pr on a Pull Request No Longer Open and Document pr_review.py's state= Fields - #3698
Merged
Merged
Conversation
….py's state= Fields Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… Exit Rule Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An active P1 finding remains in .agents/skills/drive-pr/SKILL.md because the merge path can clean up before unresolved or introduced findings receive a required disposition.
1 open issue
What changed in this PR
This pull request updates the drive-pr workflow to recognize merged and closed pull requests from pr_review.py digests, and documents the related digest fields and wait behavior.
Changes:
- Documents
state=,merged_at=,merge_commit=, andclosed_at=fields. - Handles merged and closed pull requests during the drive workflow.
- Regenerates the distributed skill copies and source digest.
- A remaining issue is that peer-merged feature PRs can bypass disposition of unresolved threads or
introducedfindings before cleanup.
| File | Description |
|---|---|
scripts/README.md |
Documents digest state and merge metadata fields, plus wait behavior for closed pull requests. |
.github/skills/drive-pr/SKILL.md |
Regenerated GitHub skill distribution. |
.claude-plugin/fleet-skills/skills/drive-pr/SKILL.md |
Regenerated Claude skill distribution. |
.claude-plugin/fleet-skills/.source-digests/drive-pr |
Updates the generated skill source digest. |
.agents/skills/drive-pr/SKILL.md |
Adds state-aware handling for merged and closed pull requests. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3698 +/- ##
========================================
Coverage 81.91% 81.91%
========================================
Files 27 27
Lines 9224 9224
========================================
Hits 7556 7556
Misses 1668 1668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 31, 2026
…ne Revision, and Place Copilot's Outstanding Findings (#3703) Promotes the changes merged into `develop` since promotion #3693 to `main`, the second round of a backlog burndown. - [#3698](#3698) Has `drive-pr` read `state=` in every digest `wait` or `status` prints. On a feature pull request a peer merged, the drive skips the merge and goes on to the post-merge path. On a promotion it reports the merge as the drive's end state. `state=CLOSED` is a stop. `state=` decides over any exit code on such a pull request. `scripts/README.md` documents the `state=`, `merged_at=`, `merge_commit=` and `closed_at=` fields. - [#3696](#3696) Has `hub_fetch_run.py` read the prose gate's companion and script twice from `main` when no hub commit resolves, refusing with "the gate did not run" when the reads differ, so a hub push between the two requests cannot pair revisions. A resolved commit is still fetched once. - [#3702](#3702) Places a Copilot overview's `Outstanding findings:` or `Unresolved review findings:` list and prints each item under FINDINGS WITH NO THREAD, marked by whether a current thread sits at its code-span `path:line`. A findings label with no readable list holds as an unplaced part. A changed file with no changed line, added, modified or deleted, is left out of the table match while a file with changed lines remains, so a table omitting only binary files reads as covering. Remaining for the maintainer, from #3702: an empty file, a mode-only change, and a text file `.gitattributes` marks `binary` or `-diff` read 0/0 like a binary file, so a Copilot table leaving one out still reads as covering. That is the trade #3489 asked for. Deferred review findings: #3697 (open findings on a peer-merged feature pull request get no outcome before cleanup in `drive-pr`) and #3700 (the three documents describing `hub_fetch_run.py`'s fallback without its new refusal). Fixes #3688 Fixes #3533 Fixes #3672 Fixes #3489 Fixes #3701 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes drive-pr read
state=in every digestwaitorstatusprints. A merged feature PR continues to step 4's post-merge path, a merged promotion PR is reported as merged, and a closed PR is a stop. Documents thestate=,merged_at=,merge_commit=, andclosed_at=fields andwait's handling of a PR no longer open in scripts/README.md.Remaining findings: open findings on a peer-merged feature PR get no stated outcome before cleanup. Filed as #3697.
Closes on promotion: #3688
🤖 Generated with Claude Code