Skip to content

Read a Copilot File Table That Leaves Out Only Binary Files as Covering Them #3489

Closed

Description

@ptr727

Summary

scripts/pr_review.py reads coverage=table only where a Copilot round's file table names exactly the changed files. Copilot's table leaves out binary files, so any pull request that changes one reads coverage=none, and Merge Gate item 2 goes unmet although every text file was read.

Reproduction

A constructed case: a pull request changing docs/a.md and static/b.png. The Copilot round's table names docs/a.md alone. pr_review.py status prints coverage=none and NO COVERAGE IS SHOWN: ... names 1 path(s) where the pull request changes 2 file(s).

It recurred twice in one Blog session. A font pull request had 17 of 27 files in the table, the other 10 being woff2. A promotion had 51 of 189, the other 138 being PNG, JPEG, WOFF2, ZIP, and MP4.

Expected

The comparison leaves out files GitHub reports as binary, or files the repository marks binary in .gitattributes. A table naming every remaining changed file then reads coverage=table, and the digest says how many binary files were left out, so the reading stays checkable.

🤖 Generated with Claude Code

Activity

  1. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Backlog burndown round 2 claim. Branch: feature/burndown-3672-3489. Group: #3672, #3489.

    Predicted file set:

    • scripts/pr_review_copilot.py
    • scripts/pr_review_rounds.py
    • scripts/pr_review_digest.py
    • scripts/pr_review.py
    • scripts/reviewers/copilot.json
    • tests/test_pr_review_copilot.py
    • tests/test_pr_review.py

    No other live group may edit these files until this branch merges or the claim is released here.

  2. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Claim update for feature/burndown-3672-3489: the group needs scripts/README.md, which feature/burndown-3688 (#3688) holds. This branch parks until #3688 merges, and scripts/README.md joins this claim then.

  3. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Claim released: feature/burndown-3672-3489 merged to develop as #3702 and its branch and worktree are cleaned up. This issue closes when the next develop -> main promotion merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions