Skip to content

pr_review.py Leaves a Copilot Overview's Outstanding Findings List Unplaced #3672

Closed

Description

@ptr727

scripts/pr_review.py status read a Copilot ccr-overview-v2 round on ptr727/Financial-Modeling#1606 and reported shapes=NOTED with a label this reader has no spelling for: \outstanding findings:``.

What the body held. Inside the collapsed What changed in this PR details, after the change bullets, Copilot wrote an Outstanding findings: list with one bullet per finding, shaped like this:

Outstanding findings:
- **Moderate, P2 — `src/pkg/module.py:193` (1 vote):** <finding text>
- **Moderate, P1 — `src/pkg/other.py:443` (3 votes):** <finding text>

The P1 bullet matched the round's one review thread. The P2 bullet had no thread and appeared nowhere else in the review. So it is a finding the reader can see only as an unplaced label, and the 1 open issue headline counts only the thread.

Why it matters. A finding that lives only in this list is one the Merge Gate's suppressed-finding handling never reaches. The NOTED line is what surfaced it here, and a reader skimming past that line would miss it.

Ask. Add a spelling for the Outstanding findings: label in scripts/reviewers/. Place each bullet as a finding at its path and line. Where a bullet matches no thread on the head, report it the way a suppressed finding is reported, so it needs an answer before the gate passes.

Activity

  1. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Backlog burndown round 2 claim. Branch: feature/burndown-3672-3489. Group: #3672, #3489.

    Predicted file set:

    • scripts/pr_review_copilot.py
    • scripts/pr_review_rounds.py
    • scripts/pr_review_digest.py
    • scripts/pr_review.py
    • scripts/reviewers/copilot.json
    • tests/test_pr_review_copilot.py
    • tests/test_pr_review.py

    No other live group may edit these files until this branch merges or the claim is released here.

  2. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Claim update for feature/burndown-3672-3489: the group needs scripts/README.md, which feature/burndown-3688 (#3688) holds. This branch parks until #3688 merges, and scripts/README.md joins this claim then.

  3. ptr727 commented on Oct 31, 2026

    @ptr727
    OwnerAuthor

    Claim released: feature/burndown-3672-3489 merged to develop as #3702 and its branch and worktree are cleaned up. This issue closes when the next develop -> main promotion merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions