Skip to content

Correct the pr_review.py Quota-Refusal Remedy Comment - #1832

Merged
ptr727 merged 2 commits into
developfrom
feature/auto-1647
Sep 25, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/auto-1647

Conversation

@ptr727

@ptr727 ptr727 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Fixes the comment pr_review.py's refusal reader carries, per #1647.

What changes

The inline comment above the refusal reader said a quota refusal is cleared by waiting, which
contradicted the module docstring's own exit-code contract for 46: a quota refusal is
account-level state that no re-request or wait clears, so the caller proceeds on the other
reviewers' coverage instead. The comment now says that. Behavior and exit codes are unchanged,
this is a comment-only fix.

Verification

ruff check passes on the changed file. The local strict review pass found no issues, recorded
against develop. The prose gate's comment-added rule fires on this edit as expected, since it
rewords an existing comment line, and this PR carries the comments label to stand it down.

Closes on promotion: #1647

🤖 Generated with Claude Code

The comment above the refusal reader said a quota refusal is cleared
by waiting, contradicting the module docstring's exit-code contract
for 46: a quota refusal is account-level state that no wait clears,
so the caller proceeds on the other reviewers' coverage instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 25, 2026 20:36
@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 828d30eb-ed9c-4293-9f84-74825dfc6637


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is comment-only and correctly aligns the inline guidance with the existing documented exit-code behavior.

Review effort: Lite
Findings: None

What changed in this PR

Updates scripts/pr_review.py to correct an inline comment about how to respond to Copilot review refusals, aligning it with the script's documented exit-code contract (quota refusals are not cleared by waiting).

Changes:

  • Rewords the refusal-remedy comment to separate file-count refusals (split PR) from quota refusals (account-level; proceed using other reviewers' coverage).
File Description
scripts/​pr_review.py Clarifies the quota-refusal remedy in the digest output comment without changing behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

gh pr create attaches a label with a separate mutation after opening the
pull request, so the opened event's payload carried no label and
validate-task.yml's allow-comments input read false. A re-run of that
same run reuses its original event payload and fails the same way. This
empty commit's synchronize event reads the label already on the pull
request.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is comment-only and now matches the already-correct exit-code contract documented in the same module.

Review effort: Lite
Findings: None

@ptr727
ptr727 merged commit 0a63183 into develop Sep 25, 2026
9 checks passed
@ptr727
ptr727 deleted the feature/auto-1647 branch September 25, 2026 20:47
ptr727 added a commit that referenced this pull request Sep 26, 2026
… Fixes to Main (#1839)

Promotes `develop` to `main`.

## Carried

- #1830: stops the prose gate reading a `#` after `$` or `${` as a
comment marker, per #1646.
- #1832: corrects the comment on the `pr_review.py` quota-refusal
remedy, per #1647.
- #1834: accepts an absent, empty, or wildcard SessionEnd matcher as
covering every exit reason, per #1638.
- #1838: routes every question and every offer of more work through the
interface's prompt mechanism, blocking or not.
- #1841: describes a SessionEnd matcher by its shape in the installer
report, following #1834.

Closes #1646
Closes #1647
Closes #1638

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants