You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ask Every Question Through the Interface's Prompt, Blocking or Not - #1838
A non-blocking question, or a closing offer of more work, was allowed as inline prose ("A single inline question is fine"), so it landed at the end of long reports where it was lost, and it carried no recommendation. The rule only reached a session through agent-conduct, whose triggers covered blocking questions but not offers, and the unattended-handoff orchestrator had no statement about asking at all.
GOVERNANCE.md "Communicating with the User": every question that is asked goes through the interface's prompt mechanism, blocking or not, an offer included. The numbered list is the fallback where no prompt exists, and it opens the message rather than closing it. Whether a question is asked now or parked as an issue stays with the parking bullet.
agent-conduct: fires whenever about to ask the user anything or offer more work. The description's leading sentence, which duplicated the trigger list and carried a stale count, is removed, taking the description from 1426 to 1266 characters.
session-handoff: "The Parked Decision Queue" intro names the reordered form bullets by their current openings.
unattended-handoff: the orchestrator's final message "writes nothing else and asks nothing".
Generated includes and distributions regenerated.
Review
Six local strict review passes recorded. Findings fixed: a stale bullet reference in session-handoff, a conflict between the new bullet and the parking bullet, and three defects in an orchestrator closing-prompt design that was then removed on the maintainer's call.
Declined, maintainer's call: the claim that the parking bullet does not rule on a non-blocking, unrecorded question. That bullet already says a question may be recorded "because the work can continue without the answer", which leaves the agent the choice, and either way an asked question goes as a prompt.
A non-blocking question or a closing offer of more work was allowed as
inline prose, so it landed at the end of long reports where it was lost,
and it carried no recommendation. Every question now goes through the
prompt mechanism with the numbered list as the fallback opening the
message, agent-conduct fires on any question or offer, and the
unattended-handoff orchestrator asks a present maintainer through the
prompt rather than in its final report.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🟢 Approval recommended
The contract change is consistently applied across the canonical sources and regenerated copies, with only minor readability nits called out in the source skill text.
Updates the fleet communication contract so that all user questions (blocking or not, including “want me to…?” offers) must be asked via the interface prompt mechanism rather than embedded in prose, and propagates that rule through the skills that surface it at decision moments.
Changes:
Replace the “numbered list / inline question” guidance with a stricter “prompt-only” rule, keeping numbered lists as the fallback when no prompt mechanism exists.
Expand agent-conduct’s trigger language to include offers of additional work as user questions.
Regenerate skill distributions so the rule is reflected consistently across source and generated copies.
File
Description
GOVERNANCE.md
Defines the new “ask every question via prompt” rule and clarifies fallback behavior.
.github/skills/unattended-handoff/SKILL.md
Updates the orchestrator’s ending behavior statement (generated copy).
.github/skills/session-handoff/SKILL.md
Updates the parked-decision explanation to reference the new bullet (generated copy).
.github/skills/agent-conduct/SKILL.md
Updates agent-conduct trigger description and included governance excerpt (generated copy).
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🟡 Changes recommended
There are small but concrete documentation-quality issues (an awkward phrase in the new governance bullet and a reintroduced awkward line wrap) that should be corrected before merging.
Get a fresh assessment by requesting another Copilot review.
The phrase "is the parking bullet's to settle" is grammatically awkward; reword to make the dependency on the parking bullet clear. (GOVERNANCE.md:223)
Declining as a pure preference, per fleet-code-review "Review the Change" item 5. The sentence names the bullet it depends on by its exact opening words ("A question filed as an issue is parked rather than asked"), so the dependency is already explicit, and three local strict review passes read it as unambiguous. No rule or reader-visible failure turns on the phrasing.
… Fixes to Main (#1839)
Promotes `develop` to `main`.
## Carried
- #1830: stops the prose gate reading a `#` after `$` or `${` as a
comment marker, per #1646.
- #1832: corrects the comment on the `pr_review.py` quota-refusal
remedy, per #1647.
- #1834: accepts an absent, empty, or wildcard SessionEnd matcher as
covering every exit reason, per #1638.
- #1838: routes every question and every offer of more work through the
interface's prompt mechanism, blocking or not.
- #1841: describes a SessionEnd matcher by its shape in the installer
report, following #1834.
Closes#1646Closes#1647Closes#1638
🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A non-blocking question, or a closing offer of more work, was allowed as inline prose ("A single inline question is fine"), so it landed at the end of long reports where it was lost, and it carried no recommendation. The rule only reached a session through
agent-conduct, whose triggers covered blocking questions but not offers, and theunattended-handofforchestrator had no statement about asking at all.GOVERNANCE.md"Communicating with the User": every question that is asked goes through the interface's prompt mechanism, blocking or not, an offer included. The numbered list is the fallback where no prompt exists, and it opens the message rather than closing it. Whether a question is asked now or parked as an issue stays with the parking bullet.agent-conduct: fires whenever about to ask the user anything or offer more work. The description's leading sentence, which duplicated the trigger list and carried a stale count, is removed, taking the description from 1426 to 1266 characters.session-handoff: "The Parked Decision Queue" intro names the reordered form bullets by their current openings.unattended-handoff: the orchestrator's final message "writes nothing else and asks nothing".Review
Six local strict review passes recorded. Findings fixed: a stale bullet reference in
session-handoff, a conflict between the new bullet and the parking bullet, and three defects in an orchestrator closing-prompt design that was then removed on the maintainer's call.Declined, maintainer's call: the claim that the parking bullet does not rule on a non-blocking, unrecorded question. That bullet already says a question may be recorded "because the work can continue without the answer", which leaves the agent the choice, and either way an asked question goes as a prompt.
🤖 Generated with Claude Code