Strip the CR From configure.sh's Environment-Name Encoding

[ptr727]

check_environments() percent-encoded the environment name with a plain jq -rn, so a native Windows jq's trailing CR reached the deployment-branch-policies API path. The read now goes through jqr like the surrounding reads. A new test drives the lifted lines with a stand-in jq that appends a CR, and it fails with the fix reverted.

Closes on promotion: #1882

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4749b0e6-b18b-46af-99aa-de16454b7f21

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟢 Approval recommended

It is a minimal, low-risk one-line fix routing through an existing helper, closely mirrors prior merged CRLF fixes and the sibling test convention, and is covered by a test that fails when reverted.

Review effort: Balanced
Findings: None

What changed in this PR

This PR fixes a CRLF-exposure bug in repo-config/configure.sh. In check_environments(), the environment name was percent-encoded with a plain jq -rn before being interpolated into a gh api deployment-branch-policies URL path. On a native Windows jq, -r raw mode appends a trailing carriage return, which would corrupt the URL path segment and cause every custom-branch-policy environment to be reported as a read failure rather than as (non-)drift. The fix routes the encoding through the existing jqr() helper, which strips the trailing CR, matching the same fix applied to the surrounding reads and to prior sites in this CRLF chain. A new test lifts the actual script lines and drives them with a stand-in jq that appends a CR, verifying the CR is stripped from the encoded name.

Changes:

• Route the environment-name @uri encoding through jqr -n instead of jq -rn, and add the file's standard SC2016 disable comment.
• Add tests/test_configure_envname.py, which exercises the lifted jqr and encoding lines under both CRLF and LF jq output and would fail with the fix reverted.

File	Description
repo-config/​configure.sh	Encode the environment name via jqr -n so the native-Windows jq trailing CR is stripped before it reaches the API URL path; adds the conventional SC2016 disable comment.
tests/​test_configure_envname.py	New test lifting the real jqr and encoding lines, asserting a CRLF-emitting jq shim leaves no CR in the encoded name and that LF output encodes identically.

I verified: jqr() at configure.sh:406 is jq -r "$@" | sed $'s/\r$//', so it strips the CR; the added SC2016 disable is consistent with the file's convention (e.g. lines 671, 700); the test structure and CRLF-shim approach mirror the established tests/test_configure_model.py; the imported lift/run_bash helpers exist in test_configure_archived.py; and the regexes in the test each match exactly one line so the fix-reverted case genuinely fails.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@dd4ca98). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2068   +/-   ##
==========================================
  Coverage           ?   55.66%           
==========================================
  Files              ?       16           
  Lines              ?     7317           
  Branches           ?        0           
==========================================
  Hits               ?     4073           
  Misses             ?     3244           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	55.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot review overview

🟢 Approval recommended

It is a minimal, well-tested fix that mirrors the file's established jqr CRLF-hardening pattern, with a regression test that fails when reverted and no unfixed raw-jq sites remaining in the affected function.

Review effort: Balanced
Findings: None