Skip to content

Let an Attested Local Pass Cover a Head Beside a Table-Less Copilot Round - #2765

Merged
ptr727 merged 4 commits into
developfrom
feature/auto-2739
Oct 11, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/auto-2739

Conversation

@ptr727

@ptr727 ptr727 commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Summary

On a pull request into a branch other than the default, a Copilot round on the head that states no coverage, has none carried to it, and carries no file table no longer displaces an attested local pass. status and wait now read review_on_head=yes coverage=local there and exit 0, rather than coverage=unstated and exit 45.

The attested reading stays narrow:

  • A Copilot round on record that states or appears to state partial coverage still blocks it, per Merge Gate item 2.
  • A head round that carries its own file table still blocks it, even one naming fewer files than the diff changed, since that table is the round's own word that it skipped a file.
  • A promotion, a truncated review history, and a refusal on the head still block it, as before.

The help text, scripts/README.md, pr-review-conduct Merge Gate item 2, and .github/copilot-instructions.md now name coverage=local, the field both attested readings share.

Tests

  • Table-less head round plus attestation: status and wait exit 0 with coverage=local.
  • The same head with no attestation still exits 45.
  • A partial-coverage round on record plus attestation is not covered.
  • A head round whose table skips a changed file plus attestation stays at 45.

Each new test fails against the code before its fix. The full suite passes (python3 -m unittest discover -s tests).

Local strict review

Three recorded passes ran. Every introduced finding was fixed, except one declined with evidence: wait on an attested head beside a round returns 0 while checks are still running. That matches what an ordinary Copilot-covered head already does. Only the held path, where wait requested nothing, polls checks. No finding is left open.

Closes on promotion: #2739

🤖 Generated with Claude Code

ptr727 and others added 4 commits October 10, 2026 21:04
…ound

On a pull request into a branch other than the default, a Copilot round on the
head that states no coverage, has none carried to it, and has no file table
standing in no longer displaces an attested local pass. `status` and `wait`
now read `coverage=local` there instead of exiting 45. A round on record that
states or appears to state partial coverage still blocks the attestation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e Rule Text

A head round whose own table names fewer files than the diff changed is
that round saying it skipped one, so the attestation no longer overrules
it. The digest line now reads in order, and the Merge Gate and Copilot
instructions name `coverage=local`, the field both attested readings share.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 11, 2026 04:16
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0bcde51d-b771-416e-92c0-1d75921c0395

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.95%. Comparing base (eb848c4) to head (e2744f4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2765      +/-   ##
===========================================
+ Coverage    59.94%   59.95%   +0.01%     
===========================================
  Files           16       16              
  Lines         8390     8394       +4     
===========================================
+ Hits          5029     5033       +4     
  Misses        3361     3361              
Flag Coverage Δ
python-3.13 59.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes have no unresolved blocking issues.

0 open findings

What changed in this PR

Updates review coverage so an attested local pass covers a table-less Copilot round on non-default heads.

Changes:

  • Adds coverage fallback logic and regression tests.
  • Updates documentation and review guidance.
  • Synchronizes generated skill files and digest.
File Description
tests/​test_pr_review.py Adds coverage regression tests.
scripts/​README.md Documents the updated behavior.
scripts/​pr_review.py Implements table-less head coverage.
.github/​skills/​pr-review-conduct/​SKILL.md Updates generated guidance.
.github/​copilot-instructions.md Updates review instructions.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md Updates generated guidance.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct Refreshes the source digest.
.agents/​skills/​pr-review-conduct/​SKILL.md Updates canonical gate guidance.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ptr727
ptr727 merged commit ab0ac31 into develop Oct 11, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-2739 branch October 11, 2026 04:22
ptr727 added a commit that referenced this pull request Oct 11, 2026
…ilure Reporting Fixes to Main (#2816)

## Summary

Promotes these pull requests from develop to main:

- #2832 Require Every CLI Script to Answer Help and Refuse Unknown
Arguments
- #2833 Exempt nopep8 as a Leading Directive in the Prose Gate
- #2815 Bind the Workspace-Edit Rule Only to an Agent Running Inside VS
Code
- #2813 Record HomeAssistant-Config's Incidental Python as a driftNote
- #2827 Read nopep8 in Any Letter Case in the Prose Gate
- #2825 Spend a Head Refusal a Later Genuine Round on That Head Answers
- #2819 Read noqa and CSpell Directives in Any Letter Case
- #2814 Judge the Prose in Front of a Trailing noqa or pylint Directive
- #2811 Name Why a Windows Tool Install Failed and Print Docker's Status
in UTF-8
- #2808 Read a Tool Name as a Prose Gate Directive Only Where It Opens
the Comment
- #2802 Name a File the Prose Gate Cannot Decode in Its Scope Line
- #2800 Read a First-Line Comment After a Byte Order Mark as Leading in
Every Language
- #2797 Name a Python File the Prose Gate Cannot Parse in Its Scope Line
- #2794 Let the Unattended Orchestrator Retry a Transient Dispatch
Failure
- #2792 Close the Remaining Blocked-Promotion Gaps in the Unattended
Worker
- #2790 Read a Carried Change Set Past the Compare Endpoint's 300-File
Ceiling
- #2784 Let a Round on the Head Outrank pr_review.py wait's Repo-Wide
Quota Reading
- #2782 Say What pr_review.py wait --min-rounds Counts and Name It at
the Timeout
- #2778 Share the Bounded Step Reader Across the Test Harnesses
- #2776 Pin the Prose Gate's Override Wiring by Structure
- #2773 Exempt a List Item's Label Separator from the Dash Rule for
Every Marker and Bold Spelling
- #2771 Strip a List Item's Opening Label for Every Marker and Bold
Spelling in the Prose Gate
- #2768 Page pr_review.py's Changed-File List Past 100 So a Large
Promotion Can State Coverage
- #2765 Let an Attested Local Pass Cover a Head Beside a Table-Less
Copilot Round

Closes #2285
Closes #2820
Closes #2818
Closes #2809
Closes #2807
Closes #1659
Closes #2796
Closes #2798
Closes #2163
Closes #1984
Closes #2614
Closes #2767
Closes #2781
Closes #2741
Closes #2775
Closes #1665
Closes #2770
Closes #2738
Closes #2758
Closes #2739

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants