Read nopep8 in Any Letter Case in the Prose Gate by ptr727 · Pull Request #2827 · ptr727/ProjectTemplate

ptr727 · 2026-10-11T17:25:45Z

Summary

pycodestyle reads nopep8 in any letter case, since it compiles its inline pattern # no(?:qa|pep8)\b with re.I. The prose gate's TOOL_DIRECTIVE matched nopep8 only in lower case, so # NOPEP8 and # NoPep8: E501 in a .py file were judged as new prose comments and drew comment-added.
TOOL_DIRECTIVE now reads nopep8 in any case.
TRAILING_DIRECTIVE did not list nopep8 at all, so prose followed by a trailing # nopep8 on the same line was not cut. It now cuts a trailing nopep8 in any case, as it already did for noqa.
The without_trailing_directive docstring names nopep8 beside noqa and type: ignore.
New constructed tests pin both leading spellings, two trailing forms, and a trailing directive standing alone. With the prose_lint.py change reverted, 5 subtests fail.

Closes on promotion: #2818

🤖 Generated with Claude Code

pycodestyle reads `nopep8` in any letter case, but the prose gate matched it only in lower case, so `# NOPEP8` and `# NoPep8: E501` in a `.py` file were judged as new prose comments. `TOOL_DIRECTIVE` now reads the name in any case, and `TRAILING_DIRECTIVE` cuts a trailing `# nopep8` in any case, as it already did for `noqa`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-11T17:25:54Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 36b136c5-a4fb-4fab-9875-9825622c4ad9

📥 Commits

Reviewing files that changed from the base of the PR and between b3d7fec and 895fae8.

📒 Files selected for processing (2)

.github/actions/prose-gate/prose_lint.py
tests/test_prose_lint.py

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

🔵 Needs a closer look

nopep8 must also be added to NOT_PROSE to prevent comment-case findings.

0 open findings

What changed in this PR

This pull request updates the prose gate to recognize case-insensitive nopep8 directives, including trailing forms.

Changes:

Updated directive matching and documentation.
Added regression tests for leading and trailing spellings.
NOT_PROSE still needs to exempt nopep8 from other prose rules.

File	Summary
`tests/test_prose_lint.py`	Adds coverage for case-insensitive leading and trailing directives.
`.github/actions/prose-gate/prose_lint.py`	Updates directive matching and documentation; requires `NOT_PROSE` coverage.

🧠 Review effort: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

codecov · 2026-10-11T17:28:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.31%. Comparing base (b3d7fec) to head (895fae8).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2827   +/-   ##
========================================
  Coverage    60.31%   60.31%           
========================================
  Files           16       16           
  Lines         8479     8479           
========================================
  Hits          5114     5114           
  Misses        3365     3365

Flag	Coverage Δ
python-3.13	`60.31% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptr727 · 2026-10-11T17:29:42Z

Answering the Copilot round on head 895fae8, whose verdict headline counts no finding (0 findings in its block):

nopep8 must also be added to NOT_PROSE to prevent comment-case findings.

Deferred to #2828. The behavior is real but pre-existing rather than introduced here. NOT_PROSE never listed nopep8, so a lower-case whole-line # nopep8 drew comment-case before this change too, and this change does not alter that. It is not specific to nopep8 either: TOOL_DIRECTIVE is read by comment-added alone by design, per the comment above it ("Read by comment-added alone rather than added to NOT_PROSE, which two gating rules share"), so # nosec B404 draws comment-case the same way. Probing check_file with the three comment rules on this head gives comment-case for # nopep8 and # nosec B404, and no finding for # NOPEP8, # nopep8: E501, or a trailing x = 1 # nopep8. #2828 records it as one class across every TOOL_DIRECTIVE name, since whether those names should also leave comment-case is a choice that design note bears on.

ptr727 · 2026-10-11T17:31:23Z

@coderabbitai review

coderabbitai · 2026-10-11T17:31:31Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…ilure Reporting Fixes to Main (#2816) ## Summary Promotes these pull requests from develop to main: - #2832 Require Every CLI Script to Answer Help and Refuse Unknown Arguments - #2833 Exempt nopep8 as a Leading Directive in the Prose Gate - #2815 Bind the Workspace-Edit Rule Only to an Agent Running Inside VS Code - #2813 Record HomeAssistant-Config's Incidental Python as a driftNote - #2827 Read nopep8 in Any Letter Case in the Prose Gate - #2825 Spend a Head Refusal a Later Genuine Round on That Head Answers - #2819 Read noqa and CSpell Directives in Any Letter Case - #2814 Judge the Prose in Front of a Trailing noqa or pylint Directive - #2811 Name Why a Windows Tool Install Failed and Print Docker's Status in UTF-8 - #2808 Read a Tool Name as a Prose Gate Directive Only Where It Opens the Comment - #2802 Name a File the Prose Gate Cannot Decode in Its Scope Line - #2800 Read a First-Line Comment After a Byte Order Mark as Leading in Every Language - #2797 Name a Python File the Prose Gate Cannot Parse in Its Scope Line - #2794 Let the Unattended Orchestrator Retry a Transient Dispatch Failure - #2792 Close the Remaining Blocked-Promotion Gaps in the Unattended Worker - #2790 Read a Carried Change Set Past the Compare Endpoint's 300-File Ceiling - #2784 Let a Round on the Head Outrank pr_review.py wait's Repo-Wide Quota Reading - #2782 Say What pr_review.py wait --min-rounds Counts and Name It at the Timeout - #2778 Share the Bounded Step Reader Across the Test Harnesses - #2776 Pin the Prose Gate's Override Wiring by Structure - #2773 Exempt a List Item's Label Separator from the Dash Rule for Every Marker and Bold Spelling - #2771 Strip a List Item's Opening Label for Every Marker and Bold Spelling in the Prose Gate - #2768 Page pr_review.py's Changed-File List Past 100 So a Large Promotion Can State Coverage - #2765 Let an Attested Local Pass Cover a Head Beside a Table-Less Copilot Round Closes #2285 Closes #2820 Closes #2818 Closes #2809 Closes #2807 Closes #1659 Closes #2796 Closes #2798 Closes #2163 Closes #1984 Closes #2614 Closes #2767 Closes #2781 Closes #2741 Closes #2775 Closes #1665 Closes #2770 Closes #2738 Closes #2758 Closes #2739 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Copilot AI lite review requested due to automatic review settings October 11, 2026 17:25

Copilot started reviewing on behalf of ptr727 October 11, 2026 17:26

View session

Copilot AI reviewed Oct 11, 2026

View reviewed changes

ptr727 mentioned this pull request Oct 11, 2026

A lower-case tool directive the prose gate exempts from comment-added still draws comment-case #2828

Closed

ptr727 merged commit 65c14a2 into develop Oct 11, 2026
14 checks passed

ptr727 deleted the feature/auto-2818 branch October 11, 2026 17:32

This was referenced Oct 11, 2026

Session Handoff [auto-2818]: Read nopep8 in Any Letter Case in the Prose Gate, for #2818 #2826

Closed

Promote Prose Gate, Review Tooling, Unattended Worker, and Install Failure Reporting Fixes to Main #2816

Merged

Navigation Menu

Repository navigation

Read nopep8 in Any Letter Case in the Prose Gate - #2827

Read nopep8 in Any Letter Case in the Prose Gate#2827
ptr727 merged 1 commit into
developfrom
feature/auto-2818

ptr727 commented Oct 11, 2026

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Review limit reached

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Oct 11, 2026

Uh oh!

ptr727 commented Oct 11, 2026

Uh oh!

ptr727 commented Oct 11, 2026

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 11, 2026

Summary

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

codecov Bot commented Oct 11, 2026

Codecov Report

Uh oh!

ptr727 commented Oct 11, 2026

Uh oh!

ptr727 commented Oct 11, 2026

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading