Repository navigation
Remove Incidental Counts the First Sweep Left in Carried Text - #3274
Merged
Merged
Conversation
Re-read each count word across AGENTS.md, GOVERNANCE.md, CODESTYLE.md, WORKFLOW.md, .github/copilot-instructions.md, and .agents/skills/ in context, and remove the counts that restate the size of an enumeration that can grow. Rename the counted headings whose list can grow, together with every citation of them: "Every finding ends in one of five outcomes" becomes "Every finding ends in a listed outcome", "The Two Seats" and "The Three Seats" become "The Seats", and "Before you touch any of these four files" drops its count. Keep the counts that are fixed by construction or relied on by an ordinal later in the text, such as the workflow models, the Python profiles, the orchestration and build layers, and the two exceptions whose prose names the first and the second. Fixes #3169 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name what audit-a-repo's pin rule, backlog-burndown's cleanup checks, and session-handoff's platform exception cover now that their count words are gone, keep copilot-instructions-keeper's pointer to the guard narrowed to instruction files, and drop the same count from scripts/README.md and local_review.py's docstring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Say "all of the reasons" rather than "all of them", since "them" bound to "the rules" in the bullet just before it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3274 +/- ##
========================================
Coverage 65.49% 65.49%
========================================
Files 17 17
Lines 10011 10011
========================================
Hits 6557 6557
Misses 3454 3454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three unresolved review findings remain, including two agreement corrections and one platform-routing correction.
1 open issue
What changed in this PR
This PR removes incidental enumeration counts from documentation and synchronizes canonical and generated skill distributions.
Changes:
- Rewords incidental counts and dependent headings.
- Updates canonical and generated skill documentation.
- Refreshes source digests while preserving fixed counts.
| File | Summary |
|---|---|
scripts/README.md |
Removes outcome count wording. |
scripts/local_review.py |
Updates matching docstring wording. |
GOVERNANCE.md |
Removes incidental count wording. |
.github/skills/workflow-ci-contract/references/test-methodology.md |
Updates scenario wording. |
.github/skills/workflow-ci-contract/references/d-guarantees.md |
Updates guarantee wording. |
.github/skills/workflow-ci-contract/references/architecture.md |
Updates architecture wording. |
.github/skills/upstream-contribution-workflow/SKILL.md |
Updates fork wording. |
.github/skills/unattended-handoff/SKILL.md |
Updates seat heading and references. |
.github/skills/skill-lifecycle/SKILL.md |
Removes lifecycle counts. |
.github/skills/session-handoff/SKILL.md |
Updates handoff wording. |
.github/skills/repo-worktree/SKILL.md |
Removes workflow counts. |
.github/skills/python-codestyle/SKILL.md |
Removes audit counts. |
.github/skills/python-codestyle/references/profiles.md |
Updates profile wording. |
.github/skills/pr-review-conduct/SKILL.md |
Renames outcome heading and references. |
.github/skills/merge-and-release/SKILL.md |
Removes path counts. |
.github/skills/local-strict-review/SKILL.md |
Updates outcome wording. |
.github/skills/git-commit-conventions/SKILL.md |
Removes signature and gate counts. |
.github/skills/drive-pr/SKILL.md |
Updates outcome references. |
.github/skills/dotnet-codestyle/SKILL.md |
Removes task and path counts. |
.github/skills/dotnet-codestyle/references/testing.md |
Updates testing wording. |
.github/skills/copilot-instructions-keeper/SKILL.md |
Removes carried-file counts. |
.github/skills/comment-and-doc-style/SKILL.md |
Removes file and reason counts. |
.github/skills/comment-and-doc-style/references/markdown-links.md |
Removes exception counts. |
.github/skills/comment-and-doc-style/references/carried-doc-references.md |
Removes file count. |
.github/skills/carried-instruction-file-guard/SKILL.md |
Removes carried-file counts. |
.github/skills/branching-and-release-model/SKILL.md |
Removes promotion count. |
.github/skills/branching-and-release-model/references/release-publish-mechanics.md |
Removes target and registry counts. |
.github/skills/backlog-burndown/SKILL.md |
Removes seat and outcome counts. |
.github/skills/audit-a-repo/SKILL.md |
Removes workflow-model counts. |
.github/skills/agent-conduct/SKILL.md |
Removes review-pass counts. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/test-methodology.md |
Updates generated scenario wording. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/d-guarantees.md |
Updates generated guarantee wording. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/architecture.md |
Updates generated architecture wording. |
.claude-plugin/fleet-skills/skills/upstream-contribution-workflow/SKILL.md |
Updates generated fork wording. |
.claude-plugin/fleet-skills/skills/unattended-handoff/SKILL.md |
Updates generated seat wording. |
.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md |
Updates generated handoff wording. |
.claude-plugin/fleet-skills/skills/repo-worktree/SKILL.md |
Updates generated worktree wording. |
.claude-plugin/fleet-skills/skills/python-codestyle/SKILL.md |
Updates generated Python wording. |
.claude-plugin/fleet-skills/skills/python-codestyle/references/profiles.md |
Updates generated profile wording. |
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md |
Updates generated outcome wording. |
.claude-plugin/fleet-skills/skills/merge-and-release/SKILL.md |
Updates generated path wording. |
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md |
Updates generated review wording. |
.claude-plugin/fleet-skills/skills/git-commit-conventions/SKILL.md |
Updates generated signature wording. |
.claude-plugin/fleet-skills/skills/drive-pr/SKILL.md |
Updates generated outcome references. |
.claude-plugin/fleet-skills/skills/dotnet-codestyle/SKILL.md |
Updates generated .NET wording. |
.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/testing.md |
Updates generated testing wording. |
.claude-plugin/fleet-skills/skills/copilot-instructions-keeper/SKILL.md |
Updates generated carried-file wording. |
.claude-plugin/fleet-skills/skills/comment-and-doc-style/SKILL.md |
Updates generated documentation wording. |
.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/markdown-links.md |
Updates generated link wording. |
.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/carried-doc-references.md |
Updates generated reference wording. |
.claude-plugin/fleet-skills/skills/carried-instruction-file-guard/SKILL.md |
Updates generated guard wording. |
.claude-plugin/fleet-skills/skills/branching-and-release-model/SKILL.md |
Updates generated branching wording. |
.claude-plugin/fleet-skills/skills/branching-and-release-model/references/release-publish-mechanics.md |
Updates generated publishing wording. |
.claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md |
Updates generated backlog wording. |
.claude-plugin/fleet-skills/skills/audit-a-repo/SKILL.md |
Updates generated audit wording. |
.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md |
Updates generated conduct wording. |
.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/upstream-contribution-workflow |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/unattended-handoff |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/skill-lifecycle |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/session-handoff |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/repo-worktree |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/python-codestyle |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/merge-and-release |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/local-strict-review |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/git-commit-conventions |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/drive-pr |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/dotnet-codestyle |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/copilot-instructions-keeper |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/comment-and-doc-style |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/carried-instruction-file-guard |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/branching-and-release-model |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/backlog-burndown |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/audit-a-repo |
Refreshes source digest. |
.claude-plugin/fleet-skills/.source-digests/agent-conduct |
Refreshes source digest. |
.agents/skills/workflow-ci-contract/references/test-methodology.md |
Updates canonical scenario wording. |
.agents/skills/workflow-ci-contract/references/d-guarantees.md |
Updates canonical guarantee wording. |
.agents/skills/workflow-ci-contract/references/architecture.md |
Updates canonical architecture wording. |
.agents/skills/upstream-contribution-workflow/SKILL.md |
Updates canonical fork wording. |
.agents/skills/unattended-handoff/SKILL.md |
Updates canonical seat wording. |
.agents/skills/skill-lifecycle/SKILL.md |
Updates canonical lifecycle wording. |
.agents/skills/session-handoff/SKILL.md |
Updates canonical handoff wording. |
.agents/skills/repo-worktree/SKILL.md |
Updates canonical worktree wording. |
.agents/skills/README.md |
Updates distribution wording. |
.agents/skills/python-codestyle/SKILL.md |
Updates canonical Python wording. |
.agents/skills/python-codestyle/references/profiles.md |
Updates canonical profile wording. |
.agents/skills/pr-review-conduct/SKILL.md |
Updates canonical outcome wording. |
.agents/skills/merge-and-release/SKILL.md |
Updates canonical merge wording. |
.agents/skills/local-strict-review/SKILL.md |
Updates canonical review wording. |
.agents/skills/git-commit-conventions/SKILL.md |
Updates canonical signature wording. |
.agents/skills/drive-pr/SKILL.md |
Updates canonical outcome references. |
.agents/skills/dotnet-codestyle/SKILL.md |
Updates canonical .NET wording. |
.agents/skills/dotnet-codestyle/references/testing.md |
Updates canonical testing wording. |
.agents/skills/copilot-instructions-keeper/SKILL.md |
Updates canonical carried-file wording. |
.agents/skills/comment-and-doc-style/SKILL.md |
Updates canonical documentation wording. |
.agents/skills/comment-and-doc-style/references/markdown-links.md |
Updates canonical link wording. |
.agents/skills/comment-and-doc-style/references/carried-doc-references.md |
Updates canonical reference wording. |
.agents/skills/carried-instruction-file-guard/SKILL.md |
Updates canonical guard wording. |
.agents/skills/branching-and-release-model/SKILL.md |
Updates canonical branching wording. |
.agents/skills/branching-and-release-model/references/release-publish-mechanics.md |
Updates canonical publishing wording. |
.agents/skills/backlog-burndown/SKILL.md |
Updates canonical backlog wording. |
.agents/skills/audit-a-repo/SKILL.md |
Updates canonical audit wording. |
.agents/skills/agent-conduct/SKILL.md |
Updates canonical conduct wording. |
Review effort: Lite
"A platform-bound issue" read as an issue meeting the platform-lane conditions, the opposite of the exception the sentence states. Name the WSL-only and Windows-only defects just listed instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
A recorded local strict-review pass covers head |
Owner
Author
|
Answering the findings Copilot's headlines name with no thread, no collapsed block, and no anchor.
No change needed, for both. Neither names a location or a sentence, so there is nothing to quote or check against. This branch's agreement was checked directly: four recorded local strict-review passes read every edited sentence for singular/plural agreement and for a pronoun or "each" binding to the wrong noun. The first and second passes' findings of that kind were fixed before the pull request opened. The one construction in the diff a Lite reviewer is most likely to read as a disagreement is correct as written. In |
This was referenced Oct 20, 2026
ptr727
added a commit
that referenced
this pull request
Oct 20, 2026
## Summary Fixes the wording finding Copilot raised on promotion [#3276](#3276) against `dotnet-codestyle/references/testing.md`. [#3274](#3274 count sweep left "Further details of it are equally load-bearing, and a failure of any of them does not red the job on its own." That sentence compared the details to nothing, and it spoke of a detail failing. It now reads "The details that follow are as load-bearing as the invocation, and getting one wrong does not red the job on its own." Here "the invocation" is the `dotnet test` command in the sentence before. It is also more accurate, since the rename that follows is a later step rather than part of that command. ## Local verification - One recorded `local-strict-review` pass over this head, with no findings. It checked each detail against `WORKFLOW.md` D1.6 and confirmed getting it wrong leaves the job green. - `build_dist.py --check` and `prose_lint.py --diff origin/develop` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Oct 20, 2026
## Summary Promotes these pull requests from develop. - [#3274](#3274): finishes the incidental-count sweep over the carried text and the skills. Counts that restated the size of an enumeration that can grow are removed, and counted headings are renamed with every citation: "Every finding ends in a listed outcome", "The Seats" in `backlog-burndown` and `unattended-handoff`, and "Before you touch any of these files". Counts fixed by construction or relied on by a later ordinal are kept. - [#3277](#3277): fixes the wording Copilot flagged on this promotion in `dotnet-codestyle/references/testing.md`. The sentence the sweep left now names the invocation the D1.6 details are weighed against. Closes #3169 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the incidental-count sweep #3169 asks for, over
AGENTS.md,GOVERNANCE.md,CODESTYLE.md,WORKFLOW.md,.github/copilot-instructions.md, and.agents/skills/. Each count word was read in its whole paragraph and judged byGOVERNANCE.md"Incidental Counts".pr-review-conduct"Every finding ends in one of five outcomes" is now "Every finding ends in a listed outcome", including thedrive-princlude marker and thelocal-strict-reviewcitations.backlog-burndown"The Two Seats" andunattended-handoff"The Three Seats" are now "The Seats".carried-instruction-file-guard"Before you touch any of these four files" drops its count.buildandlint-onlyprofiles, the orchestration and build layers, thedevelopandmainrulesets, the two-branch fork shape, and "The two exceptions", whose prose then names the first and the second.scripts/README.mdandscripts/local_review.py's docstring drop the same "five outcomes" count, so the renamed heading is not contradicted.reports/canonical-review.jsonstill holds passes keyed on the two old unit names.canonical_review.pyreports those as orphans by design, and the renamed sections are read again under their new keys, so the ledger is left as is.Closing #3169 rides on the promotion pull request.
Local verification
local-strict-reviewpasses, recorded, the last over this head with no findings. The first raised five findings and the second one more, all on wording this change wrote, and each was fixed.build_dist.py --check,repo_gate.py,spec/validate.py,canonical_review.py status,prose_lint.py --diff origin/develop,docker_lint.py, and the unit suite all pass.🤖 Generated with Claude Code