Promote the Incidental Count Sweep to Main by ptr727 · Pull Request #3276 · ptr727/ProjectTemplate

ptr727 · 2026-10-20T20:06:29Z

Summary

Promotes these pull requests from develop.

#3274: finishes the incidental-count sweep over the carried text and the skills. Counts that restated the size of an enumeration that can grow are removed, and counted headings are renamed with every citation: "Every finding ends in a listed outcome", "The Seats" in backlog-burndown and unattended-handoff, and "Before you touch any of these files". Counts fixed by construction or relied on by a later ordinal are kept.
#3277: fixes the wording Copilot flagged on this promotion in dotnet-codestyle/references/testing.md. The sentence the sweep left now names the invocation the D1.6 details are weighed against.

🤖 Generated with Claude Code

## Summary Finishes the incidental-count sweep #3169 asks for, over `AGENTS.md`, `GOVERNANCE.md`, `CODESTYLE.md`, `WORKFLOW.md`, `.github/copilot-instructions.md`, and `.agents/skills/`. Each count word was read in its whole paragraph and judged by `GOVERNANCE.md` "Incidental Counts". - **Removed** where the count restated the size of an enumeration that can grow, such as "the four files", "both registries", "all three", "two reasons", or "either refusal". Where a removal left a later "both", "neither", or pronoun bound to the old number, that word was fixed in the same edit. - **Counted headings renamed** with every citation, searched whitespace-insensitively so a wrapped citation is caught too: - `pr-review-conduct` "Every finding ends in one of five outcomes" is now "Every finding ends in a listed outcome", including the `drive-pr` include marker and the `local-strict-review` citations. - `backlog-burndown` "The Two Seats" and `unattended-handoff` "The Three Seats" are now "The Seats". - `carried-instruction-file-guard` "Before you touch any of these four files" drops its count. - **Kept** where the count is fixed by construction, or where a later ordinal relies on it: the workflow models, the Python `build` and `lint-only` profiles, the orchestration and build layers, the `develop` and `main` rulesets, the two-branch fork shape, and "The two exceptions", whose prose then names the first and the second. - `scripts/README.md` and `scripts/local_review.py`'s docstring drop the same "five outcomes" count, so the renamed heading is not contradicted. `reports/canonical-review.json` still holds passes keyed on the two old unit names. `canonical_review.py` reports those as orphans by design, and the renamed sections are read again under their new keys, so the ledger is left as is. Closing #3169 rides on the promotion pull request. ## Local verification - Three `local-strict-review` passes, recorded, the last over this head with no findings. The first raised five findings and the second one more, all on wording this change wrote, and each was fixed. - `build_dist.py --check`, `repo_gate.py`, `spec/validate.py`, `canonical_review.py status`, `prose_lint.py --diff origin/develop`, `docker_lint.py`, and the unit suite all pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-20T20:06:37Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: efad9216-a251-4110-a10b-8bfaf71d518b

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

🔵 Needs a closer look

A moderate wording issue remains in .agents/skills/dotnet-codestyle/references/testing.md.

No open issues 🎉

What changed in this PR

Promotes the incidental-count cleanup from develop to main across documentation, skill distributions, and source digests.

Changes:

Removes incidental enumeration counts.
Renames counted headings and updates citations.
Synchronizes generated skill distributions and digests.

File	Review result
`scripts/README.md`	Reviewed count cleanup.
`scripts/local_review.py`	Reviewed wording update.
`GOVERNANCE.md`	Reviewed count removal.
`.github/skills/workflow-ci-contract/references/test-methodology.md`	Reviewed documentation update.
`.github/skills/workflow-ci-contract/references/d-guarantees.md`	Reviewed documentation update.
`.github/skills/workflow-ci-contract/references/architecture.md`	Reviewed documentation update.
`.github/skills/upstream-contribution-workflow/SKILL.md`	Reviewed documentation update.
`.github/skills/unattended-handoff/SKILL.md`	Reviewed documentation update.
`.github/skills/skill-lifecycle/SKILL.md`	Reviewed documentation update.
`.github/skills/session-handoff/SKILL.md`	Reviewed documentation update.
`.github/skills/repo-worktree/SKILL.md`	Reviewed documentation update.
`.github/skills/python-codestyle/SKILL.md`	Reviewed documentation update.
`.github/skills/python-codestyle/references/profiles.md`	Reviewed documentation update.
`.github/skills/pr-review-conduct/SKILL.md`	Reviewed documentation update.
`.github/skills/merge-and-release/SKILL.md`	Reviewed documentation update.
`.github/skills/local-strict-review/SKILL.md`	Reviewed documentation update.
`.github/skills/git-commit-conventions/SKILL.md`	Reviewed documentation update.
`.github/skills/drive-pr/SKILL.md`	Reviewed documentation update.
`.github/skills/dotnet-codestyle/SKILL.md`	Reviewed documentation update.
`.github/skills/dotnet-codestyle/references/testing.md`	Reviewed documentation update.
`.github/skills/copilot-instructions-keeper/SKILL.md`	Reviewed documentation update.
`.github/skills/comment-and-doc-style/SKILL.md`	Reviewed documentation update.
`.github/skills/comment-and-doc-style/references/markdown-links.md`	Reviewed documentation update.
`.github/skills/comment-and-doc-style/references/carried-doc-references.md`	Reviewed documentation update.
`.github/skills/carried-instruction-file-guard/SKILL.md`	Reviewed documentation update.
`.github/skills/branching-and-release-model/SKILL.md`	Reviewed documentation update.
`.github/skills/branching-and-release-model/references/release-publish-mechanics.md`	Reviewed documentation update.
`.github/skills/backlog-burndown/SKILL.md`	Reviewed documentation update.
`.github/skills/audit-a-repo/SKILL.md`	Reviewed documentation update.
`.github/skills/agent-conduct/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/test-methodology.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/d-guarantees.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/architecture.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/upstream-contribution-workflow/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/unattended-handoff/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/repo-worktree/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/python-codestyle/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/python-codestyle/references/profiles.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/merge-and-release/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/git-commit-conventions/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/drive-pr/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/dotnet-codestyle/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/testing.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/copilot-instructions-keeper/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/comment-and-doc-style/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/markdown-links.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/carried-doc-references.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/carried-instruction-file-guard/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/branching-and-release-model/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/branching-and-release-model/references/release-publish-mechanics.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/audit-a-repo/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md`	Reviewed documentation update.
`.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/upstream-contribution-workflow`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/unattended-handoff`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/skill-lifecycle`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/session-handoff`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/repo-worktree`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/python-codestyle`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/pr-review-conduct`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/merge-and-release`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/local-strict-review`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/git-commit-conventions`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/drive-pr`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/dotnet-codestyle`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/copilot-instructions-keeper`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/comment-and-doc-style`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/carried-instruction-file-guard`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/branching-and-release-model`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/backlog-burndown`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/audit-a-repo`	Reviewed digest refresh.
`.claude-plugin/fleet-skills/.source-digests/agent-conduct`	Reviewed digest refresh.
`.agents/skills/workflow-ci-contract/references/test-methodology.md`	Reviewed documentation update.
`.agents/skills/workflow-ci-contract/references/d-guarantees.md`	Reviewed documentation update.
`.agents/skills/workflow-ci-contract/references/architecture.md`	Reviewed documentation update.
`.agents/skills/upstream-contribution-workflow/SKILL.md`	Reviewed documentation update.
`.agents/skills/unattended-handoff/SKILL.md`	Reviewed documentation update.
`.agents/skills/skill-lifecycle/SKILL.md`	Reviewed documentation update.
`.agents/skills/session-handoff/SKILL.md`	Reviewed documentation update.
`.agents/skills/repo-worktree/SKILL.md`	Reviewed documentation update.
`.agents/skills/README.md`	Reviewed distribution description.
`.agents/skills/python-codestyle/SKILL.md`	Reviewed documentation update.
`.agents/skills/python-codestyle/references/profiles.md`	Reviewed documentation update.
`.agents/skills/pr-review-conduct/SKILL.md`	Reviewed documentation update.
`.agents/skills/merge-and-release/SKILL.md`	Reviewed documentation update.
`.agents/skills/local-strict-review/SKILL.md`	Reviewed documentation update.
`.agents/skills/git-commit-conventions/SKILL.md`	Reviewed documentation update.
`.agents/skills/drive-pr/SKILL.md`	Reviewed documentation update.
`.agents/skills/dotnet-codestyle/SKILL.md`	Reviewed documentation update.
`.agents/skills/dotnet-codestyle/references/testing.md`	Moderate: replace “Does not red the job” with grammatical CI wording.
`.agents/skills/copilot-instructions-keeper/SKILL.md`	Reviewed documentation update.
`.agents/skills/comment-and-doc-style/SKILL.md`	Reviewed documentation update.
`.agents/skills/comment-and-doc-style/references/markdown-links.md`	Reviewed documentation update.
`.agents/skills/comment-and-doc-style/references/carried-doc-references.md`	Reviewed documentation update.
`.agents/skills/carried-instruction-file-guard/SKILL.md`	Reviewed documentation update.
`.agents/skills/branching-and-release-model/SKILL.md`	Reviewed documentation update.
`.agents/skills/branching-and-release-model/references/release-publish-mechanics.md`	Reviewed documentation update.
`.agents/skills/backlog-burndown/SKILL.md`	Reviewed documentation update.
`.agents/skills/audit-a-repo/SKILL.md`	Reviewed documentation update.
`.agents/skills/agent-conduct/SKILL.md`	Reviewed documentation update.

_{Review effort: Lite}

codecov · 2026-10-20T20:12:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.49%. Comparing base (53bc127) to head (1914fad).
⚠️ Report is 407 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3276   +/-   ##
=======================================
  Coverage   65.49%   65.49%           
=======================================
  Files          17       17           
  Lines       10011    10011           
=======================================
  Hits         6557     6557           
  Misses       3454     3454

Flag	Coverage Δ
python-3.13	`65.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

## Summary Fixes the wording finding Copilot raised on promotion [#3276](#3276) against `dotnet-codestyle/references/testing.md`. [#3274](#3274 count sweep left "Further details of it are equally load-bearing, and a failure of any of them does not red the job on its own." That sentence compared the details to nothing, and it spoke of a detail failing. It now reads "The details that follow are as load-bearing as the invocation, and getting one wrong does not red the job on its own." Here "the invocation" is the `dotnet test` command in the sentence before. It is also more accurate, since the rename that follows is a later step rather than part of that command. ## Local verification - One recorded `local-strict-review` pass over this head, with no findings. It checked each detail against `WORKFLOW.md` D1.6 and confirmed getting it wrong leaves the job green. - `build_dist.py --check` and `prose_lint.py --diff origin/develop` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

One or more issues must be addressed before approval.

No open issues 🎉

_{Review effort: Lite}

ptr727 · 2026-10-20T20:29:32Z

Answering the findings Copilot's headlines name on this promotion with no thread and no open-issue list.

Round on ab32efdf headline: "A moderate wording issue remains in .agents/skills/dotnet-codestyle/references/testing.md." (1) finding stated, with no thread and no line. Fixed in 1914fad, by #3277. The only sentence this promotion changes in that file was "Further details of it are equally load-bearing, and a failure of any of them does not red the job on its own." That compared the details to nothing and spoke of a detail failing. It now reads "The details that follow are as load-bearing as the invocation, and getting one wrong does not red the job on its own."
Round on 1914fad7 headline: "One or more issues must be addressed before approval." The same body says "No open issues", and it names no file, line, or sentence. No change needed: there is nothing to act on, and the one issue named on this pull request is fixed above. If a later round names one, it gets its own triage.

Copilot AI lite review requested due to automatic review settings October 20, 2026 20:06

ptr727 added documentation Improvements or additions to documentation skills Agent skill prose A defect in rule or procedure text labels Oct 20, 2026

Copilot started reviewing on behalf of ptr727 October 20, 2026 20:07

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

ptr727 mentioned this pull request Oct 20, 2026

Say What the D1.6 Details Are as Load-Bearing as #3277

Merged

ptr727 requested a lite review from Copilot October 20, 2026 20:24

Copilot started reviewing on behalf of ptr727 October 20, 2026 20:24

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

ptr727 mentioned this pull request Oct 20, 2026

Session Handoff [review-tooling]: Count Sweep Landed on Develop, Promotion #3276 Ready for Merge and Release #3278

Closed

ptr727 merged commit cffb54d into main Oct 20, 2026
14 checks passed

Navigation Menu

Repository navigation

Promote the Incidental Count Sweep to Main - #3276

Promote the Incidental Count Sweep to Main#3276
ptr727 merged 2 commits into
mainfrom
develop

ptr727 commented Oct 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ptr727 commented Oct 20, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

codecov Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

ptr727 commented Oct 20, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

codecov Bot commented Oct 20, 2026 •

edited

Loading