[ptr727]

Summary

A self-test or test that builds a temporary repository with git -C or cwd= inherits the GIT_DIR, GIT_INDEX_FILE, and similar variables a git hook sets, and writes into the hook's own repository. spec/audit.py --selftest cleared nothing and ran init, config, add, and commit that way.

• spec/git_env.py holds the list (what git rev-parse --local-env-vars prints), without_git_location(), and git_location_cleared().
• spec/audit.py runs its self-test inside git_location_cleared().
• scripts/local_review.py (INHERITED_REDIRECTS) and tests/test_pr_review.py (_clean_env) use the shared list.
• tests/test_git_env.py runs the audit self-test under a GIT_DIR naming a scratch repository, asserts it exits 0 with SELFTEST PASS, and asserts the scratch repository's config, history, and status are unchanged. It also checks the list covers every name the installed git prints.

Refs #3324. The host-setup/agent-safety/ item (test_install.py missing GIT_INDEX_FILE) lands in the guard lane, so this does not close the issue.

Not moved

• tests/test_pre_commit_hook.py already strips every GIT_-prefixed variable, a superset of the list, so moving it would weaken it. Left unchanged.
• scripts/pr_review.py origin_owner() keeps its own four-name strip, and the .github/actions/prose-gate/prose_lint.py copy cannot import from spec/ because it is carried downstream.

Verification

• Revert proof: with the wrapper replaced by a bare call, the new test fails on the scratch repository's changed config. With it, it passes.
• test_git_env, test_local_review, test_pr_review, test_canonical_review, test_pre_commit_hook, test_audit, audit.py --selftest, validate.py, ruff, mypy, prose gate, and the EOL gate pass.

Local review

Two passes. The first raised seven findings: the pre-commit test fixture got weaker (fixed by leaving that file unchanged), the discovery names in the list (fixed by dropping them), a docstring inaccuracy (fixed), a stale docstring claim in _clean_env (fixed), two test-quality issues (fixed). Declined: local_review now also clears GIT_DIR and GIT_CONFIG_PARAMETERS, which are on git's own list of per-repository variables, and every call there names its working directory. The second pass found nothing.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 12886f79c44940bcac1e13eecd48786e99f0204b, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: a7935ad8-ed3f-4d72-b4b6-e271cdec0210

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

The Git environment context manager must restore variables created inside the context before approval.

1 open issue

• Restore environment variables created inside the context · New

What changed in this PR

This pull request centralizes Git repository-location environment handling so self-tests and temporary-repository tests are isolated from inherited hook variables.

Changes:

• Adds shared Git environment-variable definitions and cleanup helpers in spec/git_env.py.
• Applies the helpers to the audit self-test, local review script, and PR-review fixtures.
• Adds regression coverage for Git variable completeness and audit self-test isolation.

File	Summary
tests/​test_pr_review.py	Uses the shared Git environment filtering helper for repository fixtures.
tests/​test_git_env.py	Tests environment filtering, restoration behavior, variable-list coverage, and audit self-test isolation.
spec/​git_env.py	Defines shared Git environment handling; has an unresolved restoration issue where variables created inside the context can persist, plus an unnecessary future-annotations import.
spec/​audit.py	Runs the audit self-test with Git repository-location variables cleared.
scripts/​local_review.py	Reuses the shared Git variable list for subprocess isolation.

_{Review effort: Lite}

[codecov]

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@366d8e5). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
spec/audit.py	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #3335   +/-   ##
==========================================
  Coverage           ?   65.53%           
==========================================
  Files              ?       18           
  Lines              ?    10036           
  Branches           ?        0           
==========================================
  Hits               ?     6577           
  Misses             ?     3459           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	65.53% <91.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 7dde5f0de6b88232a5be277995aaefdcedc19f05, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[ptr727]

A recorded local strict-review pass covers head 435c250884e3ed86756051c91c6f9879ef37f26c, the content this pull request carries at that commit against develop, and it recorded 0 findings.