[ptr727]

Summary

In spec/audit.py, check_interface skipped the D1.5 every-event finding for the whole workflow once any one job used the pull_request-only name expression. A second job could still post the required check on a non-PR run, and nothing flagged it.

The check now reads each job's name: together with its job key. A job's name off a pull_request run is its literal name, or the || fallback string when the name uses the pull_request-only expression. Some workflows are triggered by events other than pull_request. In those, every job whose off-PR name equals the required check gets its own DRIFT, and the finding names that job. The other jobs no longer affect it.

The existing missing-name DRIFT keeps its develop behaviour. It covers names that are neither a literal nor the pull_request-only expression, and it still flags an expression whose two branches are both the required name on a pull_request-only workflow. It now runs alongside the per-job check rather than ahead of it.

• A job falling back to the required name, with no gated job. It reports both findings, and both are true. The PR run never posts the check, and a non-PR run does.
• An expression whose two branches are both the required name, on a dispatch-triggered workflow. It reports only its per-job finding. That job does post the check on the PR run, so the missing-name finding would be false there.

Repro on a constructed stub triggered by pull_request and workflow_dispatch:

• A literal sibling. One job is named by the D1.5 expression, and a second carries the literal Check pull request workflow status job. This returned [] before the change. It now returns one DRIFT naming the second job.
• A fallback sibling. The second job is named ${{ github.event_name == 'pull_request' && 'Other job' || 'Check pull request workflow status job' }}. This also returned [] before the change. It now returns one DRIFT naming that job.

Unchanged: a gated job alone raises no finding. A literal name on a pull_request-only workflow raises no finding either.

Tests

New INTERFACE_CASES rows in tests/test_audit_helpers.py:

• A literal sibling beside a gated job.
• A fallback sibling beside a gated job.
• Two literal jobs, one finding each.
• A fallback-only job, both findings.
• An every-event expression on a dispatch-triggered workflow, one finding.
• A fallback job beside an every-event expression naming another check, both findings.

Two new tests assert which job each finding names, and that the dispatch every-event case reports its per-job finding rather than the generic one. Run against develop's spec/audit.py, every new row fails except the dispatch every-event row. That row keeps develop's count, so its message test is what pins it. The last row also fails if the suppression stops checking for the required name.

spec/audit.py --selftest and the full OPERATIONS.md "Local Verification" block pass.

Closes on promotion: #3334

🤖 Generated with Claude Code

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/burn-3797-fix1
• File: .coderabbit.yaml
• Commit: 9549ecb
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 06dedc43-00a9-47b5-9c0f-fbc929a5f60d

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[ptr727]

A recorded local strict-review pass covers head 01118f071fe01924646618888ba51f8b48e5a780, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟡 Changes recommended

A moderate finding in spec/audit.py shows fallback-only job names bypass the per-job classification and omit the offending job key, leaving the new behavior incomplete.

1 open issue

• Handle fallback-only names in the per-job classification path · New

What changed in this PR

This pull request updates the D1.5 workflow interface audit to evaluate each job’s effective name on runs other than pull_request, preventing one correctly gated job from masking another offending job.

Changes:

• Tracks job names alongside their job keys.
• Reports each offending job with a separate drift finding.
• Adds coverage for literal siblings, fallback expressions, and multiple offending jobs.
• Updates the finding wording to describe non-pull_request runs.

File	Summary	Findings
tests/​test_audit_helpers.py	Adds regression coverage for sibling, fallback, duplicate-name, and job-specific finding scenarios.	Nit: Rename the test at line 663 so its name reflects the non-pull_request behavior rather than “every event.” (1 vote)
spec/​audit.py	Implements per-job required-check name analysis and reporting.	Moderate/P2: Fallback-only names bypass the per-job path, so findings do not identify the offending job. (2 votes) Nit: Remove the standalone comment near line 994 because it adds a comment-gate obligation without documenting non-obvious rationale. (1 vote)

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (ac508e1) to head (9549ecb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3799      +/-   ##
===========================================
+ Coverage    82.71%   82.72%   +0.01%     
===========================================
  Files           29       29              
  Lines         9626     9629       +3     
===========================================
+ Hits          7962     7966       +4     
+ Misses        1664     1663       -1     

Flag	Coverage Δ
python-3.13	82.72% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 5cee26196d4f1baccee148f2ad3a22832ba240ec, the content this pull request carries at that commit against develop, and it recorded 2 findings.

[ptr727]

A recorded local strict-review pass covers head 9549ecba4dfa70060530bf3f7fc0a7623551e03c, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[ptr727]

Answers to the Copilot round on 01118f0. Its FINDINGS WITH NO THREAD block counted (1), and its overview table names two findings that sit on no thread, so each is answered below.

• tests/test_audit_helpers.py:663, "Rename the test at line 663 so its name reflects the non-pull_request behavior rather than 'every event.'" Fixed in 43c5b1a. It is now test_the_off_pull_request_finding_names_the_job_beside_a_gated_one.
• spec/audit.py:994, "Remove the standalone comment near line 994 because it adds a comment-gate obligation without documenting non-obvious rationale." No change needed. The comment gives the reason findings are counted per job: neither a gated job nor a missing one excuses another job that yields the name off a pull_request run. The pooled read it replaces is the defect this pull request fixes, so the reason is the non-obvious part. The PR carries the comments label for it.