Skip to content

Flag the .NET Coverage Upload and Tick the PlexCleaner Stage 3, 4, and 5 Items - #3848

Merged
ptr727 merged 11 commits into
developfrom
fix/3834-plexcleaner-tracker
Nov 3, 2026
Merged

ptr727 merged 11 commits into
developfrom
fix/3834-plexcleaner-tracker

Conversation

@ptr727

@ptr727 ptr727 commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

The ticks do not claim a clean interface audit. A hub audit of PlexCleaner main reports one interface drift unrelated to these tasks: its check-workflow-status name ignores workflow_dispatch (D1.5), unlike catalog/snippets/workflows/test-pull-request-smoke.yml.

Local review findings

Every introduced finding the local passes raised is fixed on this head, and the last pass (4da738af) raised none. The flag's doc text sits in a paragraph of its own after the per-leg .NET note. The guard test reads the step through the shared yaml_step/yaml_value helpers.

Test plan

  • Prose gate (diff-scoped), actionlint, markdownlint, and the pre-commit hook pass locally.
  • tests/test_release_guards.py (35 tests) passes. The new test_validator_dotnet_upload_carries_a_fixed_flag fails when flags: dotnet is removed from the workflow.
  • Every PlexCleaner claim re-verified against main through gh reads by three local review passes.
  • CI on this pull request.

Closes #3834
Closes #3819

🤖 Generated with Claude Code

ptr727 and others added 3 commits November 2, 2026 21:42
…d 5 Items

validate-task.yml uploads the .NET unit-test coverage under a fixed
`dotnet` flag, mirroring the Python leg's `python-<version>`, so a caller
declaring its own Codecov flags can report the unit-test share per flag.

PlexCleaner#940 (`0e9b0b9`, carried on `main`) adopted the hub's
publish-plan-task.yml, build-release-task.yml, and
publish-docker-readme-task.yml by pin and deleted its get-version-task.yml
copy, so the tracker ticks its Stage 3 and Stage 4 items and adds a
Stage 5 checkbox.

Closes #3834
Closes #3819

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 3, 2026 05:49
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active documentation issue incorrectly implies that every caller must configure the Codecov dotnet flag, so the wording should be qualified for callers that use flags.

1 open issue
What changed in this PR

This pull request adds a fixed dotnet Codecov flag for .NET unit-test coverage and updates the PlexCleaner reusable-workflow adoption tracker for Stages 3–5.

Changes:

  • Adds the dotnet flag to the .NET Codecov upload.
  • Documents the flag alongside the existing Python coverage flags.
  • Marks PlexCleaner adoption entries for Stages 3, 4, and 5 as complete.
  • Two nit findings remain in docs/reusable-workflows.md: qualify the flag requirement for callers that configure Codecov flags, and remove the stale incidental count.
File Summary
docs/​reusable-workflows.md Documents Codecov flag behavior and updates PlexCleaner adoption entries. Two nit findings remain at line 487 (4 votes and 1 vote).
.github/​workflows/​validate-task.yml Adds the fixed dotnet Codecov flag to .NET coverage uploads.

This pull request is ready to be approved.

Review effort: Lite

Comment thread docs/reusable-workflows.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.30%. Comparing base (536bddb) to head (4da738a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3848   +/-   ##
========================================
  Coverage    83.30%   83.30%           
========================================
  Files           29       29           
  Lines         9937     9937           
========================================
  Hits          8278     8278           
  Misses        1659     1659           
Flag Coverage Δ
python-3.13 83.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptr727 and others added 2 commits November 2, 2026 21:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 19673bfa7aeb13b429aa580646cf67e06522eb7a, the content this pull request carries at that commit against develop, and it recorded 1 finding.

ptr727 and others added 3 commits November 2, 2026 22:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ct the Guard's Premise

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 4da738af39cf47662a21c077d7dc100ab51cab3c, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727
ptr727 merged commit 5802070 into develop Nov 3, 2026
13 checks passed
@ptr727
ptr727 deleted the fix/3834-plexcleaner-tracker branch November 3, 2026 06:21
ptr727 added a commit that referenced this pull request Nov 3, 2026
…er Tracker Items (#3849)

Promotes the changes merged into `develop` since promotion #3843 to
`main`.

- [#3848](#3848) uploads
the .NET unit-test coverage in `validate-task.yml` under a fixed
`dotnet` Codecov flag, beside the Python legs' own flags, with a
release-guard test pinning it. It also ticks the PlexCleaner Stage 3 and
Stage 4 items in `docs/reusable-workflows.md` and adds a ticked Stage 5
item, after re-checking PlexCleaner `main`.
- [#3850](#3850) answers
this promotion's Copilot finding, naming the upload on both sides of
that guard test's docstring.

Fixes #3834
Fixes #3819

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants