Repository navigation
Flag the .NET Coverage Upload and Tick the PlexCleaner Stage 3, 4, and 5 Items - #3848
Conversation
…d 5 Items validate-task.yml uploads the .NET unit-test coverage under a fixed `dotnet` flag, mirroring the Python leg's `python-<version>`, so a caller declaring its own Codecov flags can report the unit-test share per flag. PlexCleaner#940 (`0e9b0b9`, carried on `main`) adopted the hub's publish-plan-task.yml, build-release-task.yml, and publish-docker-readme-task.yml by pin and deleted its get-version-task.yml copy, so the tracker ticks its Stage 3 and Stage 4 items and adds a Stage 5 checkbox. Closes #3834 Closes #3819 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
An active documentation issue incorrectly implies that every caller must configure the Codecov dotnet flag, so the wording should be qualified for callers that use flags.
1 open issue
What changed in this PR
This pull request adds a fixed dotnet Codecov flag for .NET unit-test coverage and updates the PlexCleaner reusable-workflow adoption tracker for Stages 3–5.
Changes:
- Adds the
dotnetflag to the .NET Codecov upload. - Documents the flag alongside the existing Python coverage flags.
- Marks PlexCleaner adoption entries for Stages 3, 4, and 5 as complete.
- Two nit findings remain in
docs/reusable-workflows.md: qualify the flag requirement for callers that configure Codecov flags, and remove the stale incidental count.
| File | Summary |
|---|---|
docs/reusable-workflows.md |
Documents Codecov flag behavior and updates PlexCleaner adoption entries. Two nit findings remain at line 487 (4 votes and 1 vote). |
.github/workflows/validate-task.yml |
Adds the fixed dotnet Codecov flag to .NET coverage uploads. |
This pull request is ready to be approved.
Review effort: Lite
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3848 +/- ##
========================================
Coverage 83.30% 83.30%
========================================
Files 29 29
Lines 9937 9937
========================================
Hits 8278 8278
Misses 1659 1659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ct the Guard's Premise Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
…er Tracker Items (#3849) Promotes the changes merged into `develop` since promotion #3843 to `main`. - [#3848](#3848) uploads the .NET unit-test coverage in `validate-task.yml` under a fixed `dotnet` Codecov flag, beside the Python legs' own flags, with a release-guard test pinning it. It also ticks the PlexCleaner Stage 3 and Stage 4 items in `docs/reusable-workflows.md` and adds a ticked Stage 5 item, after re-checking PlexCleaner `main`. - [#3850](#3850) answers this promotion's Copilot finding, naming the upload on both sides of that guard test's docstring. Fixes #3834 Fixes #3819 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Summary
validate-task.ymluploads the .NET unit-test coverage under a fixeddotnetCodecov flag, mirroring the Python leg'spython-<version>. A caller declaring its own flags (PlexCleaner's coverage plan, Raise .NET Coverage Past 80% Without Testing Unused Code PlexCleaner#1194 step 5) can then report the .NET unit-test share per flag. A caller declaring no flags sees no change in its unflagged total.docs/reusable-workflows.mdnames the flag beside the Python one, and a release-guard test pins it.mainwas re-checked. Resync With the Hub, Migrate to MTP, and Adopt the Reusable Workflow Chain PlexCleaner#940 (0e9b0b9, merged todevelop2026-08-30, an ancestor ofmain) deleted itsget-version-task.ymlcopy. The same change adopted the hub'spublish-plan-task.yml(theplanjob),build-release-task.yml(publish and smoke jobs) andpublish-docker-readme-task.yml, each by pin. So the Stage 3 and Stage 4 PlexCleaner items are ticked, and Stage 5 gains a ticked PlexCleaner checkbox, each in the form of the ticked items around it.The ticks do not claim a clean
interfaceaudit. A hub audit of PlexCleanermainreports oneinterfacedrift unrelated to these tasks: itscheck-workflow-statusname ignoresworkflow_dispatch(D1.5), unlikecatalog/snippets/workflows/test-pull-request-smoke.yml.Local review findings
Every
introducedfinding the local passes raised is fixed on this head, and the last pass (4da738af) raised none. The flag's doc text sits in a paragraph of its own after the per-leg .NET note. The guard test reads the step through the sharedyaml_step/yaml_valuehelpers.Test plan
tests/test_release_guards.py(35 tests) passes. The newtest_validator_dotnet_upload_carries_a_fixed_flagfails whenflags: dotnetis removed from the workflow.mainthroughghreads by three local review passes.Closes #3834
Closes #3819
🤖 Generated with Claude Code