Repository navigation
Name the Upload on Both Sides of the dotnet Flag Guard's Docstring - #3850
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change is limited to clarifying a test docstring without altering test logic or assertions.
No open issues 🎉
What changed in this PR
This pull request clarifies the test_validator_dotnet_upload_carries_a_fixed_flag docstring by explicitly naming the Python-leg upload in the comparison. Test behavior and coverage remain unchanged.
Changes:
- Adds the missing
uploadnoun to the docstring. - Preserves the existing test logic and assertions.
| File | Description |
|---|---|
tests/test_release_guards.py |
Clarifies the .NET coverage-upload test docstring. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3850 +/- ##
========================================
Coverage 83.30% 83.30%
========================================
Files 29 29
Lines 9937 9937
========================================
Hits 8278 8278
Misses 1659 1659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…er Tracker Items (#3849) Promotes the changes merged into `develop` since promotion #3843 to `main`. - [#3848](#3848) uploads the .NET unit-test coverage in `validate-task.yml` under a fixed `dotnet` Codecov flag, beside the Python legs' own flags, with a release-guard test pinning it. It also ticks the PlexCleaner Stage 3 and Stage 4 items in `docs/reusable-workflows.md` and adds a ticked Stage 5 item, after re-checking PlexCleaner `main`. - [#3850](#3850) answers this promotion's Copilot finding, naming the upload on both sides of that guard test's docstring. Fixes #3834 Fixes #3819 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Answers a Copilot finding on promotion PR #3849: the
test_validator_dotnet_upload_carries_a_fixed_flagdocstring read "from a Python leg's where their paths overlap", which drops the noun. It now names the upload on both sides of the comparison.Test plan
tests/test_release_guards.pypasses locally (35 tests).🤖 Generated with Claude Code