Stop supporting Python 3.4 to run mypy #6564

Activity

1. ilevkivskyi commented on Mar 18, 2019

   

   ilevkivskyi

   on Mar 18, 2019

   Member

   More actions

   +1 from me. Some PRs fail on 3.4 because it has some syntax limitations, I think the latest example is Michael's union PR.
2. JukkaL commented on Mar 19, 2019

   

   JukkaL

   on Mar 19, 2019

   Collaborator

   More actions

   Let's do this.

   I think that mypyc doesn't support 3.4. This means that once we ship a mypyc-compiled mypy by default, we should either drop 3.4 support or add Python 3.4 support to mypyc. The latter seems pointless because of the EoL, so dropping 3.4 support seems to make the most sense from this point of view as well.
3. emmatyping

   self-assigned this

   on Mar 26, 2019
4. emmatyping

   closed this as completedon Mar 26, 2019
5. emmatyping

   reopened this on Mar 26, 2019
6. emmatyping commented on Mar 26, 2019

   

   emmatyping

   on Mar 26, 2019

   Member

   More actions

   Apologies, fat fingered. I am about ready with a PR.
7. emmatyping

   closed this as completedin #6592on Mar 27, 2019
8. emmatyping

   added a commit that references this issue on Mar 27, 2019

   Drop support for running with 3.4 (#6592)

   ...

   This issue will close once commit affb032 is merged into the 'master' branch.

   affb032
9. astrojuanlu

   added a commit that references this issue on Jul 16, 2019

   Add minimum Python version to packaging metadata

   ...

   6aebac8
10. JukkaL

    added a commit that references this issue on Jul 17, 2019

    Add minimum Python version to packaging metadata (#7222)

    ...

    61644b7