Repository navigation
Drop support for running with 3.4 - #6592
Merged
Merged
Conversation
Closed
JukkaL
reviewed
Mar 26, 2019
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! It's great to be able to drop 3.4 workarounds. I found a few remaining 3.4 references that should probably be updated in tox.ini.
gvanrossum
reviewed
Mar 26, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM, but see Jukka's comment about tox.
I also found references to 3.3 (!) in fastparse.py and fastparse2.py.
emmatyping
commented
Mar 26, 2019
gvanrossum
approved these changes
Mar 26, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Have you tried to run it with 3.4? Does it even make it to that error message? For all entry points?
msullivan
reviewed
Mar 26, 2019
Member
Author
Yes I checked this in a docker container with 3.4.10, it does indeed cause the error to be shown. I tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6564
This PR was a bit larger than I expected, but after the test failure in #6591 I am keen to move forward with dropping support for 3.4.