Repository navigation
Allow type ignores after type comments - #6591
Merged
Merged
Conversation
This is a bit of a hack in fastparse, but allows for the following to pass typechecking: `x = 1 # type: str # type: ignore` Fixes python#5967
This was referenced Mar 26, 2019
Closed
gvanrossum
reviewed
Mar 26, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Thanks! I've wanted this many times. Here are a few nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack in fastparse, but allows for the following to pass typechecking:
x = 1 # type: str # type: ignoreThis also handles the edge case where there is a
# type: ignorein a comment, which we don't want to pick up. See the tests for more examples.Fixes #5967