You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verify list items in each tab matches the mocks in the issue description.
Also verify that buttons and icons in the list item like works correctly (like - view, submit, arrow down)
Verify that no errors appear in the JS console
Offline tests
Requires internet connection to load reports page data.
QA Steps
Go to reports page
Explore all the tabs in the sidebar
Verify list items in each tab matches the mocks in the issue description.
Also verify that buttons and icons in the list item like works correctly (like - view, submit, arrow down)
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Add extra-small button size support with new styling
Implement responsive report search header with adaptive layouts
Add accessibility labels and improve icon handling
Enhance transaction item row layout for narrow screens
Add new spacing and sizing utility styles
Diagram Walkthrough
flowchart LR
A["Button Components"] -->|extraSmall prop| B["Extra-small Styling"]
C["Constants"] -->|EXTRA_SMALL size| D["Dropdown Button Size"]
E["Spacing Utils"] -->|new utilities| F["Layout Adjustments"]
G["Report Search"] -->|responsive design| H["Adaptive Header"]
I["Transaction Rows"] -->|narrow layout| J["Improved Mobile View"]
B --> K["Updated Styles"]
D --> K
F --> K
H --> K
J --> K
Loading
File Walkthrough
Relevant files
Configuration changes
1 files
index.ts
Add extra-small button size and accessibility labels
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: No audit logs: UI interactions like expand/collapse (toggle button presses) were added without any visible logging of these critical user actions, which may be acceptable for purely presentational changes but cannot be confirmed from the diff alone.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: Missing error handling: Newly added logic for rendering transactions and bottom borders introduces UI state paths without any visible error handling or fallback for undefined props (e.g., columns, violations) which may be handled elsewhere but cannot be verified from the diff.
Unify the expand/collapse toggle button logic by having AnimatedCollapsible manage its rendering for all screen sizes, instead of duplicating the button's rendering logic in various list header components for mobile.
// In TransactionGroupListItem.tsxconstonExpandIconPress=()=>setIsExpanded(!isExpanded);constgetHeader=()=>{// ...return<ReportListItemHeaderonDownArrowClick={onExpandIconPress}isExpanded={isExpanded}.../>;}return(<AnimatedCollapsibleheader={getHeader()}onPress={onExpandIconPress}isExpanded={isExpanded}shouldShowToggleButton={isLargeScreenWidth}// Only shows toggle button on desktop>{/* ... */}</AnimatedCollapsible>);
After:
// In TransactionGroupListItem.tsxconstgetHeader=()=>{// ...// No longer needs to pass down expand/collapse propsreturn<ReportListItemHeader ... />;}return(<AnimatedCollapsibleheader={getHeader()}isExpanded={isExpanded}onPress={()=>setIsExpanded(!isExpanded)}// The component itself handles where and how to render the toggle button based on screen size>{/* ... */}</AnimatedCollapsible>);
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies duplicated rendering logic for the expand/collapse button across different components, but the proposed solution of centralizing it in AnimatedCollapsible would increase its complexity and might not be a clear improvement.
Low
General
Add accessibility state for expansion
Add the accessibilityState prop to the PressableWithFeedback component to indicate its expanded or collapsed state for better accessibility.
Why: The suggestion correctly adds the accessibilityState prop to improve screen reader support for the newly added collapsible component.
Low
Replace switch-true with if-else statements
Replace the switch (true) statement in getIconWidthAndHeightStyle with if/else statements to improve logic clarity and prevent potential bugs from multiple true flags.
[To ensure code accuracy, apply this suggestion manually]
Suggestion importance[1-10]: 5
__
Why: The suggestion correctly identifies that a switch (true) on boolean flags can be fragile and proposes a more robust if/else structure, improving code clarity and preventing potential bugs.
Low
Optimize callback dependency array
Optimize the isLastTransaction callback by changing its dependency from the visibleTransactions array to visibleTransactions.length.
Why: The suggestion correctly optimizes the useCallback dependency array, which can prevent unnecessary re-renders.
Low
More
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Benchmark PR Expensify#71448
Type: Clean (correct implementation)
Original PR Title: Clean up report page styles
Original PR Description:
Explanation of Change
Fixed Issues
$ Expensify#70369
PROPOSAL: Expensify#70369 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4
Original PR URL: Expensify#71448
PR Type
Enhancement
Description
Add extra-small button size support with new styling
Implement responsive report search header with adaptive layouts
Add accessibility labels and improve icon handling
Enhance transaction item row layout for narrow screens
Add new spacing and sizing utility styles
Diagram Walkthrough
File Walkthrough
1 files
Add extra-small button size and accessibility labels32 files
Add extraSmall prop to dropdown button typesAdd extraSmall prop to settlement button typesAdd extra-small button styles and border stylingUpdate icon sizing and button style utilitiesAdd new spacing utility classesAdd component size and width variablesAdd toggle button visibility and border stylingAdd custom styling props for display nameAdd XXSmall icon size supportImplement extra-small button size variantSupport extra-small dropdown button sizeAdd extraSmall icon size parameterAdd responsive padding and button press handlerUpdate padding for large screen widthAdd text and container styling propsImplement responsive header with adaptive stylingWrap search table header with responsive containerAdd extra-small button and badge supportAdd expand/collapse arrow for mobile viewAdd expand/collapse arrow for mobile viewReorganize layout and add expand/collapse controlsUpdate font weight stylingAdd bottom border styling and improve layoutAdd expand/collapse callbacks to headersUpdate padding for responsive layoutImplement responsive user info and action layoutUpdate text styling for responsive displayAdd text indicator option and improve spacingAdd expand/collapse arrow for mobile viewSupport extra-small button size variantUpdate skeleton dimensions and use transformRefactor narrow layout and add bottom border1 files
Update test identifiers for user info indicator