Repository navigation
Fix JNI registration bug: HermesSamplingProfiler.disable() calls enable() - #56174
elirangoshen wants to merge 1 commit into
Conversation
`HermesSamplingProfiler::registerNatives()` maps the JNI "disable" method to `HermesSamplingProfiler::enable` instead of `HermesSamplingProfiler::disable` (copy-paste bug). This causes a SIGABRT crash on Android when any profiling tool (e.g. Sentry) calls disable() to stop profiling — the sampling thread state gets corrupted and pthread_kill is called on an invalid pthread_t, which on Bionic libc triggers abort(). Fixes: react#56120
|
Hi @elirangoshen! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D97489621. |
|
@cortinico merged this pull request in 7f2a58e. |
|
This pull request was successfully merged by @elirangoshen in 7f2a58e When will my fix make it into a release? | How to file a pick request? |
Summary:
HermesSamplingProfiler::registerNatives()maps the JNI"disable"method toHermesSamplingProfiler::enableinstead ofHermesSamplingProfiler::disable(copy-paste bug). This means callingHermesSamplingProfiler.disable()from Java actually callsenable()again, which corrupts the sampling thread state.This causes a SIGABRT crash on Android when any profiling tool (e.g. Sentry) calls
disable()to stop profiling:The fix is a one-character change:
::enable→::disable.Related issue: #56120
Changelog:
[ANDROID] [FIXED] - Fix HermesSamplingProfiler.disable() JNI registration calling enable() instead of disable()
Test Plan:
This is a copy-paste bug fix visible by code inspection. The correct
disable()C++ implementation already exists (line 20-24, callshermesAPI->disableSamplingProfiler()) — it was just never invoked due to the incorrect JNI registration.Verified in production at Expensify: with this fix applied via patch-package, the SIGABRT crash no longer occurs when Sentry Hermes profiling is enabled.