Skip to content

Fix JNI registration bug: HermesSamplingProfiler.disable() calls enable() - #56174

Closed
elirangoshen wants to merge 1 commit into
react:mainfrom
elirangoshen:fix/hermes-sampling-profiler-disable-jni-registration
Closed

elirangoshen wants to merge 1 commit into
react:mainfrom
elirangoshen:fix/hermes-sampling-profiler-disable-jni-registration

Conversation

@elirangoshen

Copy link
Copy Markdown
Contributor

Summary:

HermesSamplingProfiler::registerNatives() maps the JNI "disable" method to HermesSamplingProfiler::enable instead of HermesSamplingProfiler::disable (copy-paste bug). This means calling HermesSamplingProfiler.disable() from Java actually calls enable() again, which corrupts the sampling thread state.

This causes a SIGABRT crash on Android when any profiling tool (e.g. Sentry) calls disable() to stop profiling:

Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid (hermes-sampling)
Abort message: 'invalid pthread_t passed to pthread_kill'

The fix is a one-character change: ::enable → ::disable.

Related issue: #56120

Changelog:

[ANDROID] [FIXED] - Fix HermesSamplingProfiler.disable() JNI registration calling enable() instead of disable()

Test Plan:

This is a copy-paste bug fix visible by code inspection. The correct disable() C++ implementation already exists (line 20-24, calls hermesAPI->disableSamplingProfiler()) — it was just never invoked due to the incorrect JNI registration.

Verified in production at Expensify: with this fix applied via patch-package, the SIGABRT crash no longer occurs when Sentry Hermes profiling is enabled.

`HermesSamplingProfiler::registerNatives()` maps the JNI "disable"
method to `HermesSamplingProfiler::enable` instead of
`HermesSamplingProfiler::disable` (copy-paste bug).

This causes a SIGABRT crash on Android when any profiling tool
(e.g. Sentry) calls disable() to stop profiling — the sampling
thread state gets corrupted and pthread_kill is called on an
invalid pthread_t, which on Bionic libc triggers abort().

Fixes: react#56120
@meta-cla

meta-cla Bot commented Mar 20, 2026

Copy link
Copy Markdown

Hi @elirangoshen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2026
@meta-cla

meta-cla Bot commented Mar 20, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 20, 2026
@meta-codesync

meta-codesync Bot commented Mar 20, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D97489621.

@meta-codesync

meta-codesync Bot commented Mar 20, 2026

Copy link
Copy Markdown

@cortinico merged this pull request in 7f2a58e.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @elirangoshen in 7f2a58e

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants