Repository navigation
fix: dimension table freezes when resizing the dimension column in DimensionTable.svelte - #9944
Merged
Merged
Conversation
Since #9746 migrated DimensionTable.svelte to runes, the column width $effect assigned estimateColumnSize and then read it back through estimateColumnSize[0] = manualDimensionColumnWidth. In Svelte 5 an effect that reads a source it just wrote registers it as a dependency and reschedules itself, so the first manual resize looped until effect_update_depth_exceeded. Compute the widths as a $derived instead.
AdityaHegde
approved these changes
Sep 24, 2026
AdityaHegde
pushed a commit
that referenced
this pull request
Sep 24, 2026
Since #9746 migrated DimensionTable.svelte to runes, the column width $effect assigned estimateColumnSize and then read it back through estimateColumnSize[0] = manualDimensionColumnWidth. In Svelte 5 an effect that reads a source it just wrote registers it as a dependency and reschedules itself, so the first manual resize looped until effect_update_depth_exceeded. Compute the widths as a $derived instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
effect_update_depth_exceeded.DimensionTable.svelteto runes and converted the column width$:block to an$effectverbatim. The effect assignedestimateColumnSizeand then read it back throughestimateColumnSize[0] = manualDimensionColumnWidth. In Svelte 5 an effect that reads a source it just wrote registers it as its own dependency and reschedules itself, so the first manual resize looped forever. That branch only runs after a resize, which is why the table loaded fine.estimateColumnSizewith$derived.byinstead of writing$stateinside an effect.Checklist: