Skip to content

fix: dimension table freezes when resizing the dimension column in DimensionTable.svelte #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaHegde merged 1 commit into from
Sep 24, 2026
Merged

fix: dimension table freezes when resizing the dimension column in DimensionTable.svelte #9944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions web-common/src/features/dashboards/dimension-table/DimensionTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ TableCells – the cell contents.
/* set context for child components */
setContext("config", config);

let estimateColumnSize: number[] = $state([]);

/* Separate out dimension column */
let dimensionColumn = $derived(
columns?.find((c) => c.name == dimensionName) as VirtualizedTableColumns,
Expand Down Expand Up @@ -150,19 +148,17 @@ TableCells – the cell contents.
untrack(() => $rowVirtualizer.setOptions(options));
});

$effect(() => {
if (rows && columns) {
estimateColumnSize = estimateColumnSizes(
columns,
columnWidths,
rows,
config,
);

if (manualDimensionColumnWidth !== null) {
estimateColumnSize[0] = manualDimensionColumnWidth;
}
// Derived, not an effect that assigns `$state`: an effect that writes `estimateColumnSize` and
// then reads it back (`estimateColumnSize[0] = ...`) registers the value it just wrote as its
// own dependency, so Svelte reschedules it forever. That branch only runs once the dimension
// column has been resized manually, which is why the table only froze on column resize.
let estimateColumnSize: number[] = $derived.by(() => {
if (!rows || !columns) return [];
const sizes = estimateColumnSizes(columns, columnWidths, rows, config);
if (manualDimensionColumnWidth !== null) {
sizes[0] = manualDimensionColumnWidth;
}
return sizes;
});

const columnVirtualizer = createVirtualizer<HTMLDivElement, HTMLDivElement>({
Expand Down
Loading