Repository navigation
m68k-unknown-none-elf: Remove code model and change CPU to base MC68000 - #161152
techmetx11 wants to merge 2 commits into
Conversation
|
These commits modify compiler targets. |
|
Failed to set assignee to
|
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @knickish (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
cc @knickish (sorry) |
This comment has been minimized.
This comment has been minimized.
|
Marking as blocked until the target maintainer has a chance to take a look. |
|
I'm not confident that we can reliably generate M68000 code in the LLVM backend yet. Use of the MOVE from CCR instructions is still fairly pervasive, and I'm not confident that we've unwound all of the cases where it will be emitted. I would accept a PR to just drop the code model, if that helps at all |
…lkertdev m68k-unknown-none-elf: Remove code model Extension of rust-lang#161152 cc @knickish
m68k-unknown-none-elf: Remove code model Extension of rust-lang/rust#161152 cc @knickish
This PR removes the code model because it causes issues when compiling with
rustc_codegen_gcc(the code model option doesn't exist in GCC for m68k), and changes the CPU fromM68010toM68000, since it seems like an arbitrary CPU choice over the first CPU in the Motorola 68000 series that the compiler can compile forr? @knickish