You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
m68k-unknown-none-elf's target spec has the code model set to medium which causes rustc_codegen_gcc to insert -mcmodel=medium in the GCC command-line options. Since GCC m68k doesn't support this option, it prematurely errors with libgccjit.so: error: unrecognized command-line option '-mcmodel=medium'
This PR fixes the issue by making rustc_codegen_gcc ignore the code model setting if the target architecture is m68k
Would it make more sense to fix the issue upstream in the Rust repo?
(i.e. can cg_llvm set the code model on that target?)
Perhaps by removing the code model from this target spec?
Would it make more sense to fix the issue upstream in the Rust repo? (i.e. can cg_llvm set the code model on that target?) Perhaps by removing the code model from this target spec?
Probably would, since the m68k-unknown-linux-gnu target spec has no code model set. I don't know why the code model is set specifically for this target
This PR isn't needed anymore, since the change I made to m68k-unknown-none-elf's target spec to get rid of its code model (rust-lang/rust#163995) has been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m68k-unknown-none-elf's target spec has the code model set tomediumwhich causes rustc_codegen_gcc to insert-mcmodel=mediumin the GCC command-line options. Since GCC m68k doesn't support this option, it prematurely errors withlibgccjit.so: error: unrecognized command-line option '-mcmodel=medium'This PR fixes the issue by making rustc_codegen_gcc ignore the code model setting if the target architecture is m68k