rework handling of doc attributes on macro calls - #161514
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-attributes
| error[E0658]: this subset of the `doc` attribute is meant for internal use only | ||
| --> $DIR/feature-gate-rustdoc_internals.rs:11:3 | ||
| | | ||
| LL | #[doc(fake_variadic)] |
Member
There was a problem hiding this comment.
Could you make this point to fake_variadic rather than doc?
JonathanBrouwer
requested changes
Aug 22, 2026
rustbot
added
S-waiting-on-author
JonathanBrouwer
requested changes
Aug 22, 2026
mejrs
force-pushed
the
move_doc_feature_gating
branch
from
August 22, 2026 22:16
639ab86 to
6c8b490
Compare
This comment has been minimized.
This comment has been minimized.
mejrs
force-pushed
the
move_doc_feature_gating
branch
from
August 22, 2026 22:32
6c8b490 to
34bac0b
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Aug 28, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
| no_args_and_not_crate_level!(search_unbox) | ||
| } | ||
| Some(sym::rust_logo) => { | ||
| // FIXME: Only feature gated at the crate level (!!) |
Member
There was a problem hiding this comment.
Could you document all the things that need to be fixed in issues? I think that's this
| } | ||
|
|
||
| // FIXME accidentally allowed on Stable Rust | ||
| if target == Target::MacroCall && is_doc_non_lit_expr(attr) { |
Member
There was a problem hiding this comment.
And this
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 28, 2026
…onathanBrouwer rework handling of doc attributes on macro calls rust-lang#160904 but with the fcw changes removed r? @JonathanBrouwer
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #161934 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#161934), which was unapproved. |
mejrs
force-pushed
the
move_doc_feature_gating
branch
from
August 28, 2026 18:01
34bac0b to
6d61487
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
mejrs
force-pushed
the
move_doc_feature_gating
branch
from
August 28, 2026 18:06
6d61487 to
ab7d048
Compare
This comment has been minimized.
This comment has been minimized.
mejrs
force-pushed
the
move_doc_feature_gating
branch
from
August 28, 2026 19:33
ab7d048 to
9529e2d
Compare
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
…onathanbrouwer rework handling of doc attributes on macro calls rust-lang#160904 but with the fcw changes removed r? @JonathanBrouwer
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
…onathanbrouwer rework handling of doc attributes on macro calls rust-lang#160904 but with the fcw changes removed r? @JonathanBrouwer
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 29, 2026
Rollup of 7 pull requests Successful merges: - #160941 (Enforce safety comments on `alloc`) - #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off) - #157968 (Preserve ambiguous glob lint for subtrait method picks) - #161514 (rework handling of doc attributes on macro calls) - #161944 (rustdoc: Take into account edition information for keyword highlighting) - #161974 (remove rustc_never_type_options attr remnants) - #161978 (Move rustdoc ui doctests into the right testsuite) Failed merges: - #161702 (Use `drop_guard` in some places in {core,alloc,std})
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 30, 2026
Rollup merge of #161514 - mejrs:move_doc_feature_gating, r=jonathanbrouwer rework handling of doc attributes on macro calls #160904 but with the fcw changes removed r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#160904 but with the fcw changes removed
r? @JonathanBrouwer