Move rustdoc ui doctests into the right testsuite - #161978
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
GuillaumeGomez
commented
Aug 29, 2026
Member
Author
There was a problem hiding this comment.
The needed binary to run this test doesn't exist anymore. However we now have:
$ git grep -n test-runtool
run-make/rustdoc/default-output/output-default.stdout:143: --test-runtool The tool to run tests with when building for a different target than host
run-make/rustdoc/default-output/output-default.stdout:145: --test-runtool-arg One argument (of possibly many) to pass to the runtool
run-make/rustdoc/doctest/runtool/rmake.rs:3:// Tests behavior of rustdoc `--test-runtool`.
run-make/rustdoc/doctest/runtool/rmake.rs:16:// Behavior with --test-runtool with relative paths and --test-run-directory.
run-make/rustdoc/doctest/runtool/rmake.rs:32: .arg("--test-runtool")
run-make/rustdoc/doctest/test_harness/rmake.rs:26: .arg("--test-runtool")So I think it's fine.
fmease
reviewed
Aug 29, 2026
fmease
approved these changes
Aug 29, 2026
fmease
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
cleanup-ui-doctest
branch
from
August 29, 2026 16:04
9ba715b to
484c850
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
cleanup-ui-doctest
branch
from
August 29, 2026 19:34
484c850 to
0feecd6
Compare
Member
Author
|
@bors r=fmease rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 29, 2026
Rollup of 7 pull requests Successful merges: - #160941 (Enforce safety comments on `alloc`) - #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off) - #157968 (Preserve ambiguous glob lint for subtrait method picks) - #161514 (rework handling of doc attributes on macro calls) - #161944 (rustdoc: Take into account edition information for keyword highlighting) - #161974 (remove rustc_never_type_options attr remnants) - #161978 (Move rustdoc ui doctests into the right testsuite) Failed merges: - #161702 (Use `drop_guard` in some places in {core,alloc,std})
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 30, 2026
Rollup merge of #161978 - GuillaumeGomez:cleanup-ui-doctest, r=fmease Move rustdoc ui doctests into the right testsuite When working on #161944 (comment), I realized that a lot of doctests in `rustdoc-html` testsuite were not in the correct testsuite, so moving them in the right location. Because you're the one who made me realize it, here goes @fmease (thanks!) :p r? @fmease
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #161944 (comment), I realized that a lot of doctests in
rustdoc-htmltestsuite were not in the correct testsuite, so moving them in the right location.Because you're the one who made me realize it, here goes @fmease (thanks!) :p
r? @fmease