Skip to content

PassWrapper: adapt for removal of EABIVersion arg in LLVM 24 - #162822

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-24-eabi-options
Sep 16, 2026
Merged

PassWrapper: adapt for removal of EABIVersion arg in LLVM 24#162822
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-24-eabi-options

Conversation

@durin42

@durin42 durin42 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

We never set this to anything but the default that I noticed, and now it's derived from the target triple in LLVM 24.

@rustbot label: +llvm-main

@durin42
PassWrapper: adapt for removal of EABIVersion arg in LLVM 24
bc1f40f 
We never set this to anything but the default that I noticed, and now
it's derived from the target triple in LLVM 24.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2026
@rustbot

rustbot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Sep 15, 2026
@cuviper

cuviper commented Sep 15, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bc1f40f has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 15, 2026
Merged
@cuviper cuviper mentioned this pull request Sep 15, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 16, 2026
@bors
Auto merge of #162827 - JonathanBrouwer:rollup-JmKukFg, r=JonathanBro…
28e8a8c 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #161873 (move bug and span_bug macros to rustc_span)
 - #162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - #162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - #162787 (Fix suggestions for names captured by formatting macros)
 - #159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - #162813 (Pre lint port cleanups)
 - #162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
@rust-bors
rust-bors Bot merged commit 1ffe14b into rust-lang:main Sep 16, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 16, 2026
@bors
Unrolled build for #162822 in rollup 162827
2b1a174 
Rollup merge of #162822 - durin42:llvm-24-eabi-options, r=cuviper

PassWrapper: adapt for removal of EABIVersion arg in LLVM 24

We never set this to anything but the default that I noticed, and [now](llvm/llvm-project#222672) it's derived from the target triple in LLVM 24.

@rustbot label: +llvm-main
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Sep 17, 2026
@bors
Auto merge of #162827 - JonathanBrouwer:rollup-JmKukFg, r=JonathanBro…
11ee8e7 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#161873 (move bug and span_bug macros to rustc_span)
 - rust-lang/rust#162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - rust-lang/rust#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - rust-lang/rust#162787 (Fix suggestions for names captured by formatting macros)
 - rust-lang/rust#159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - rust-lang/rust#162813 (Pre lint port cleanups)
 - rust-lang/rust#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
@durin42 durin42 mentioned this pull request Sep 17, 2026
Merged
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Sep 18, 2026
@bors
Auto merge of #162827 - JonathanBrouwer:rollup-JmKukFg, r=JonathanBro…
fa73f67 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#161873 (move bug and span_bug macros to rustc_span)
 - rust-lang/rust#162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - rust-lang/rust#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - rust-lang/rust#162787 (Fix suggestions for names captured by formatting macros)
 - rust-lang/rust#159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - rust-lang/rust#162813 (Pre lint port cleanups)
 - rust-lang/rust#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162903 - durin42:llvm-24-exception-model-fl…
75882d7 
…ag, r=cuviper

PassWrapper: adapt to LLVM reading exception model from module flag

As with rust-lang#162822, LLVM 24 [is now](llvm/llvm-project@73c8b54) reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162903 - durin42:llvm-24-exception-model-fl…
cd7f3b7 
…ag, r=cuviper

PassWrapper: adapt to LLVM reading exception model from module flag

As with rust-lang#162822, LLVM 24 [is now](llvm/llvm-project@73c8b54) reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Unrolled build for #162903 in rollup 162989
e690d58 
Rollup merge of #162903 - durin42:llvm-24-exception-model-flag, r=cuviper

PassWrapper: adapt to LLVM reading exception model from module flag

As with #162822, LLVM 24 [is now](llvm/llvm-project@73c8b54) reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Sep 19, 2026
@JonathanBrouwer
Rollup merge of #162903 - durin42:llvm-24-exception-model-flag, r=cuv…
ad6dd72 
…iper

PassWrapper: adapt to LLVM reading exception model from module flag

As with rust-lang/rust#162822, LLVM 24 [is now](llvm/llvm-project@73c8b54) reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main
pull Bot pushed a commit to xtqqczze/rust-lang-stdarch that referenced this pull request Sep 23, 2026
@JonathanBrouwer
Rollup merge of #162903 - durin42:llvm-24-exception-model-flag, r=cuv…
6b7bd1e 
…iper

PassWrapper: adapt to LLVM reading exception model from module flag

As with rust-lang/rust#162822, LLVM 24 [is now](llvm/llvm-project@73c8b54) reading exception model from the module flags instead of taking it as an extra parameter here.

@rustbot label: +llvm-main
renovate-bot pushed a commit to renovate-bot/rust-lang-_-compiler-builtins that referenced this pull request Sep 29, 2026
@bors
Auto merge of #162827 - JonathanBrouwer:rollup-JmKukFg, r=JonathanBro…
94639bc 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#161873 (move bug and span_bug macros to rustc_span)
 - rust-lang/rust#162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - rust-lang/rust#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - rust-lang/rust#162787 (Fix suggestions for names captured by formatting macros)
 - rust-lang/rust#159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - rust-lang/rust#162813 (Pre lint port cleanups)
 - rust-lang/rust#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
makai410 pushed a commit to makai410/rust that referenced this pull request Oct 1, 2026
@bors
Auto merge of rust-lang#162827 - JonathanBrouwer:rollup-JmKukFg, r=Jo…
210ceb5 
…nathanBrouwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang#161873 (move bug and span_bug macros to rustc_span)
 - rust-lang#162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - rust-lang#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - rust-lang#162787 (Fix suggestions for names captured by formatting macros)
 - rust-lang#159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - rust-lang#162813 (Pre lint port cleanups)
 - rust-lang#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Oct 1, 2026
@bors
Auto merge of #162827 - JonathanBrouwer:rollup-JmKukFg, r=JonathanBro…
2097af4 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#161873 (move bug and span_bug macros to rustc_span)
 - rust-lang/rust#162584 (Use File::*lock*() in rustc_data_structures::flock when possible)
 - rust-lang/rust#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code)
 - rust-lang/rust#162787 (Fix suggestions for names captured by formatting macros)
 - rust-lang/rust#159562 (Windows: cache the stdio write mode for the duration of a lock session)
 - rust-lang/rust#162813 (Pre lint port cleanups)
 - rust-lang/rust#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)
@github-actions github-actions Bot mentioned this pull request Oct 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@durin42 @rustbot @cuviper