Repository navigation
Refactor CodeGen Pipeline Setup into a Single Function - #162556
Merged
rust-bors[bot] merged 3 commits intoOct 2, 2026
Merged
rust-bors[bot] merged 3 commits into
rust-bors[bot] merged 3 commits into
Conversation
rustbot
added
A-LLVM
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @cuviper (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
boomanaiden154
force-pushed
the
rustc-legacy-pm-refactoring-9-9-26
branch
from
September 14, 2026 16:37
3d1a7ac to
55d2be6
Compare
This comment has been minimized.
This comment has been minimized.
cuviper
requested changes
Sep 15, 2026
Member
There was a problem hiding this comment.
Note, this will conflict with #162822, but that will hopefully be easy to merge first and then rebase this PR.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
This patch refactors setup of the LegacyPassManager for CodeGen into a single function. This simplifies some things (lifetime for the LegacyPM object), but is primarily aimed at enabling rustc to use the new runCodeGenPipeline abstraction (introduced in LLVM 24) which handles all of these details within LLVM and additionally defaults to the NewPM when a target opts-in/the correct LLVM flag is passed.
boomanaiden154
force-pushed
the
rustc-legacy-pm-refactoring-9-9-26
branch
from
September 24, 2026 14:58
55d2be6 to
dc7db04
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 2, 2026
Rollup of 8 pull requests Successful merges: - #162556 (Refactor CodeGen Pipeline Setup into a Single Function) - #163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases) - #163621 (core: Unstably constify `abort_immediate`) - #161904 (declare C and C-unwind as mutually ABI-compatible) - #163144 (Add Tier 3 targets for Hyperlight guests) - #163537 (remove unnecessary panic from opsem inhabitedness calculation) - #163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.) - #163606 (ignore hanging next-solver tests, remove unnecessary ignore test) Failed merges: - #163572 (Update the minimum external LLVM to 22)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 2, 2026
Rollup merge of #162556 - boomanaiden154:rustc-legacy-pm-refactoring-9-9-26, r=cuviper Refactor CodeGen Pipeline Setup into a Single Function This patch refactors setup of the LegacyPassManager for CodeGen into a single function. This simplifies some things (lifetime for the LegacyPM object), but is primarily aimed at enabling rustc to use the new runCodeGenPipeline abstraction (introduced in LLVM 24) which handles all of these details within LLVM and additionally defaults to the NewPM when a target opts-in/the correct LLVM flag is passed.
LorrensP-2158466
pushed a commit
to LorrensP-2158466/miri
that referenced
this pull request
Oct 6, 2026
Rollup of 8 pull requests Successful merges: - rust-lang/rust#162556 (Refactor CodeGen Pipeline Setup into a Single Function) - rust-lang/rust#163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases) - rust-lang/rust#163621 (core: Unstably constify `abort_immediate`) - rust-lang/rust#161904 (declare C and C-unwind as mutually ABI-compatible) - rust-lang/rust#163144 (Add Tier 3 targets for Hyperlight guests) - rust-lang/rust#163537 (remove unnecessary panic from opsem inhabitedness calculation) - rust-lang/rust#163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.) - rust-lang/rust#163606 (ignore hanging next-solver tests, remove unnecessary ignore test) Failed merges: - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch refactors setup of the LegacyPassManager for CodeGen into a single function. This simplifies some things (lifetime for the LegacyPM object), but is primarily aimed at enabling rustc to use the new runCodeGenPipeline abstraction (introduced in LLVM 24) which handles all of these details within LLVM and additionally defaults to the NewPM when a target opts-in/the correct LLVM flag is passed.