ignore hanging next-solver tests, remove unnecessary ignore test by lcnr · Pull Request #163606 · rust-lang/rust

lcnr · 2026-10-01T14:30:28Z

no clue why #114196 used ignore-test here 🤣

here are the compile times with the new solver right now, let's ignore the ones with a clear cause I don't care about too much right now

  314.551960  [ui] tests/ui/closures/supertrait-hint-cycle.rs
   47.479099  [ui] tests/ui/traits/issue-91949-hangs-on-recursion.rs
   46.887560  [ui] tests/ui/recursion/issue-83150.rs
   26.139618  [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration-2.rs
   25.931186  [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration.rs
   25.240523  [ui] tests/ui/try-trait/deep-try-chain-issue-153583.rs
   24.969846  [ui] tests/ui/type-alias-impl-trait/error-tainting-issue-122904.rs
   21.847410  [ui] tests/ui/consts/const-eval/issue-52475.rs
   19.111621  [ui] tests/ui/threads-sendsync/mpsc_stress.rs
   18.606682  [ui] tests/ui/process/process-panic-after-fork.rs
   14.375541  [ui] tests/ui/type-alias-impl-trait/hkl_forbidden.rs
   12.675839  [ui] tests/ui/type-alias-impl-trait/self-referential-4.rs
   11.886663  [ui] tests/ui/panic-runtime/lto-abort.rs

r? types

lqd · 2026-10-01T16:05:21Z

r? me @bors r+ rollup

rust-bors · 2026-10-01T16:05:24Z

📌 Commit d5a81cb has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

rust-bors · 2026-10-01T16:08:16Z

❌ Commit d5a81cb has been unapproved due to PR CI failure. Reapprove it with @bors r+ force if you want to ignore the failure.

rust-log-analyzer · 2026-10-01T16:12:57Z

The job test-aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

lqd · 2026-10-01T16:36:48Z

weird CI failure. I've checked locally in case but there's of course no hangs in the changed tests (all but one is ignored)...

ignore hanging next-solver tests, remove unnecessary ignore test try-job: test-aarch64-gnu-llvm-21-1

lqd · 2026-10-01T16:37:39Z

Triggering CI.

lqd · 2026-10-01T20:56:29Z

This time CI passed, so it likely was a temporary builder glitch.

@bors r+

rust-bors · 2026-10-01T20:56:33Z

❌ Cannot approve commit d5a81cb, because CI currently fails on this PR. Use @bors r+ force to override the PR CI check.

lqd · 2026-10-01T20:58:16Z

❌ Cannot approve commit d5a81cb, because CI currently fails on this PR

I beg to differ, bot!

@bors r+ force

rust-bors · 2026-10-01T20:58:19Z

📌 Commit d5a81cb has been approved by lqd

It is now in the queue for this repository.

Warning

This PR was force-approved despite failing PR CI.

lqd · 2026-10-01T21:00:42Z

here's a command to fix bors' internal state, whether or not it gets rolled up before it ends will not matter. The "PR CI failure" is a manually canceled try build, AFAICT. PR CI passed.

@bors try jobs=test-aarch64-gnu-llvm-21-1

ignore hanging next-solver tests, remove unnecessary ignore test try-job: test-aarch64-gnu-llvm-21-1

rust-bors · 2026-10-01T22:06:19Z

☀️ Try build successful (CI)
Build commit: 5db01c2 (5db01c2cbc318f4fb88f868d23a2e46e956fcbb9)
Base parent: c36f145 (c36f1457196e315bc204b9564a6a5a7fe7f5a51f)

Rollup of 8 pull requests Successful merges: - #162556 (Refactor CodeGen Pipeline Setup into a Single Function) - #163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases) - #163621 (core: Unstably constify `abort_immediate`) - #161904 (declare C and C-unwind as mutually ABI-compatible) - #163144 (Add Tier 3 targets for Hyperlight guests) - #163537 (remove unnecessary panic from opsem inhabitedness calculation) - #163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.) - #163606 (ignore hanging next-solver tests, remove unnecessary ignore test) Failed merges: - #163572 (Update the minimum external LLVM to 22)

Rollup merge of #163606 - lcnr:ui-test-suite-cleanup, r=lqd ignore hanging next-solver tests, remove unnecessary ignore test no clue why #114196 used `ignore-test` here 🤣 here are the compile times with the new solver right now, let's ignore the ones with a clear cause I don't care about too much right now ``` 314.551960 [ui] tests/ui/closures/supertrait-hint-cycle.rs 47.479099 [ui] tests/ui/traits/issue-91949-hangs-on-recursion.rs 46.887560 [ui] tests/ui/recursion/issue-83150.rs 26.139618 [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration-2.rs 25.931186 [ui] tests/ui/type-alias-impl-trait/recursive-drop-elaboration.rs 25.240523 [ui] tests/ui/try-trait/deep-try-chain-issue-153583.rs 24.969846 [ui] tests/ui/type-alias-impl-trait/error-tainting-issue-122904.rs 21.847410 [ui] tests/ui/consts/const-eval/issue-52475.rs 19.111621 [ui] tests/ui/threads-sendsync/mpsc_stress.rs 18.606682 [ui] tests/ui/process/process-panic-after-fork.rs 14.375541 [ui] tests/ui/type-alias-impl-trait/hkl_forbidden.rs 12.675839 [ui] tests/ui/type-alias-impl-trait/self-referential-4.rs 11.886663 [ui] tests/ui/panic-runtime/lto-abort.rs ``` r? types

Rollup of 8 pull requests Successful merges: - rust-lang/rust#162556 (Refactor CodeGen Pipeline Setup into a Single Function) - rust-lang/rust#163254 (rustdoc: Fix where-clause placement of free const items & checked type aliases) - rust-lang/rust#163621 (core: Unstably constify `abort_immediate`) - rust-lang/rust#161904 (declare C and C-unwind as mutually ABI-compatible) - rust-lang/rust#163144 (Add Tier 3 targets for Hyperlight guests) - rust-lang/rust#163537 (remove unnecessary panic from opsem inhabitedness calculation) - rust-lang/rust#163570 (Add tests for `!` and `bool`'s size and alignment to `coretests`.) - rust-lang/rust#163606 (ignore hanging next-solver tests, remove unnecessary ignore test) Failed merges: - rust-lang/rust#163572 (Update the minimum external LLVM to 22)

rustbot assigned BoxyUwU Oct 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 1, 2026

lcnr force-pushed the ui-test-suite-cleanup branch from 0c67389 to e4a16d2 Compare October 1, 2026 14:32

ignore hanging next-solver tests, remove unnecessary ignore test

d5a81cb

lcnr force-pushed the ui-test-suite-cleanup branch 2 times, most recently from f6d291f to d5a81cb Compare October 1, 2026 14:47

rustbot assigned lqd and unassigned BoxyUwU Oct 1, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 1, 2026

Auto merge of #163606 - lcnr:ui-test-suite-cleanup, r=<try>

dba90aa

ignore hanging next-solver tests, remove unnecessary ignore test try-job: test-aarch64-gnu-llvm-21-1

This comment was marked as outdated.

Sign in to view

lqd closed this Oct 1, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2026

lqd reopened this Oct 1, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 1, 2026

Auto merge of #163606 - lcnr:ui-test-suite-cleanup, r=<try>

5db01c2

ignore hanging next-solver tests, remove unnecessary ignore test try-job: test-aarch64-gnu-llvm-21-1

jhpratt mentioned this pull request Oct 2, 2026

Rollup of 8 pull requests #163630

Merged

rust-bors Bot merged commit 398c579 into rust-lang:main Oct 2, 2026
30 of 43 checks passed

rustbot added this to the 1.101.0 milestone Oct 2, 2026

github-actions Bot mentioned this pull request Oct 4, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

lcnr mentioned this pull request Oct 8, 2026

Stabilize the next-generation trait solver rust-lang/goals#113

Open

Conversation

lcnr commented Oct 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lqd commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

rust-log-analyzer commented Oct 1, 2026

Uh oh!

lqd commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

lqd commented Oct 1, 2026

Uh oh!

lqd commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

lqd commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

lqd commented Oct 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lcnr commented Oct 1, 2026 •

edited by rustbot

Loading

lqd commented Oct 1, 2026 •

edited

Loading