mgca: fix issue with mismatched array valtree/valtree tys by khyperia · Pull Request #162845 · rust-lang/rust

khyperia · 2026-09-16T09:00:04Z

reimplements #158587 in a different way (please see that PR for context, much of this PR's diff is undoing that PR's diff)

r? @BoxyUwU

rustbot · 2026-09-16T09:00:10Z

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

khyperia · 2026-09-16T09:27:19Z

this was a draft PR because I wasn't sure what to do about the not-great error message formatting. It's due to this:

rust/compiler/rustc_middle/src/ty/print/pretty.rs

Lines 1910 to 1918 in 28e8a8c

    
           // If it is a branch with an array, and this array can be printed as raw bytes, then dump its bytes 
        
           (ty::ValTreeKind::Branch(_), ty::Array(t, _)) 
        
               if t == u8_type 
        
                   && let Some(bytes) = cv.try_to_raw_bytes(self.tcx()) => 
        
           { 
        
               write!(self, "*")?; 
        
               self.pretty_print_byte_str(bytes)?; 
        
               return Ok(()); 
        
           }

but looks like the wonky [u8] formatting is intentional, or at least pre-existing behavior asserted in a .stderr already, introduced in #151296

un-drafting, since this PR is fine as-is, not like we're forced to fix the formatting in this PR since it's not a new issue

rustbot · 2026-09-16T09:27:35Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

HIR ty lowering was modified

cc @fmease

BoxyUwU

those are some fantastic diagnostics, want to open an issue about this? xd

we probably shouldn't be showing the value of the elements of the array on a length mismatch since it's not useful information

View changes since this review

BoxyUwU · 2026-09-16T09:58:59Z

r=me when CI green

khyperia · 2026-09-16T11:15:34Z

those are some fantastic diagnostics, want to open an issue about this? xd

#162851

khyperia · 2026-09-17T05:06:43Z

@bors r=BoxyUwU rollup

rust-bors · 2026-09-17T05:06:46Z

📌 Commit babc228 has been approved by BoxyUwU

It is now in the queue for this repository.

@BoxyUwU

…BoxyUwU mgca: fix issue with mismatched array valtree/valtree tys fixes rust-lang#160553 reimplements rust-lang#158587 in a different way (please see that PR for context, much of this PR's diff is undoing that PR's diff) r? @BoxyUwU

Rollup of 16 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window)

@BoxyUwU

…BoxyUwU mgca: fix issue with mismatched array valtree/valtree tys fixes rust-lang#160553 reimplements rust-lang#158587 in a different way (please see that PR for context, much of this PR's diff is undoing that PR's diff) r? @BoxyUwU

…uwer Rollup of 24 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162177 (Properly implement the gpu-kernel ABI for amdgpu) - #162411 (Make Receiver `#[rustc_dyn_incompatible_trait]`) - #162760 (yeet alias new_from_def_id) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162312 (core: Rewrite docs for try_as_dyn) - #162785 (Avoid creating overlapping assignments in MatchBranchSimplification) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window) - #162865 (Complex conjugate, negation and default) - #162874 (Add support for `annotate_snippets::snippet::AnnotationKind::Visible`) - #162881 (Simplify the macro for forwarding Decoder methods ) - #162888 (Fix a typo on the Armv7-R platform docs page)

…uwer Rollup of 23 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162411 (Make Receiver `#[rustc_dyn_incompatible_trait]`) - #162760 (yeet alias new_from_def_id) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162312 (core: Rewrite docs for try_as_dyn) - #162785 (Avoid creating overlapping assignments in MatchBranchSimplification) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window) - #162865 (Complex conjugate, negation and default) - #162874 (Add support for `annotate_snippets::snippet::AnnotationKind::Visible`) - #162881 (Simplify the macro for forwarding Decoder methods ) - #162888 (Fix a typo on the Armv7-R platform docs page)

@BoxyUwU

Rollup merge of #162845 - khyperia:lowering-array-len-ty, r=BoxyUwU mgca: fix issue with mismatched array valtree/valtree tys fixes #160553 reimplements #158587 in a different way (please see that PR for context, much of this PR's diff is undoing that PR's diff) r? @BoxyUwU

rustbot assigned BoxyUwU Sep 16, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2026

khyperia mentioned this pull request Sep 16, 2026

reintroduce check RibKind::ConstParamTy did in direct consts #162842

Merged

khyperia marked this pull request as ready for review September 16, 2026 09:27

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 16, 2026

mgca: fix issue with mismatched array valtree/valtree tys

babc228

khyperia force-pushed the lowering-array-len-ty branch from 4edb410 to babc228 Compare September 16, 2026 09:41

BoxyUwU approved these changes Sep 16, 2026

View reviewed changes

khyperia mentioned this pull request Sep 16, 2026

mgca: const array diagnostics aren't great #162851

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026

Zalathar mentioned this pull request Sep 17, 2026

Rollup of 16 pull requests #162887

Closed

khyperia mentioned this pull request Sep 17, 2026

ICE expected len of array pat to be definite #162864

Open

JonathanBrouwer mentioned this pull request Sep 17, 2026

Rollup of 24 pull requests #162893

Closed

JonathanBrouwer mentioned this pull request Sep 17, 2026

Rollup of 23 pull requests #162907

Merged

rust-bors Bot merged commit 065ca0f into rust-lang:main Sep 17, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 17, 2026

khyperia deleted the lowering-array-len-ty branch September 18, 2026 07:01

Navigation Menu

Uh oh!

mgca: fix issue with mismatched array valtree/valtree tys - #162845

mgca: fix issue with mismatched array valtree/valtree tys#162845
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
khyperia:lowering-array-len-ty

khyperia commented Sep 16, 2026 •

edited

Loading

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

khyperia commented Sep 16, 2026 •

edited

Loading

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

BoxyUwU left a comment •

edited by rustbot

Loading

Uh oh!

BoxyUwU commented Sep 16, 2026

Uh oh!

khyperia commented Sep 16, 2026

Uh oh!

khyperia commented Sep 17, 2026

Uh oh!

rust-bors Bot commented Sep 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

khyperia commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

khyperia commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

BoxyUwU left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Sep 16, 2026

Uh oh!

khyperia commented Sep 16, 2026

Uh oh!

khyperia commented Sep 17, 2026

Uh oh!

rust-bors Bot commented Sep 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khyperia commented Sep 16, 2026 •

edited

Loading

khyperia commented Sep 16, 2026 •

edited

Loading

BoxyUwU left a comment •

edited by rustbot

Loading