Stabilize CommandExt::show_window - #162856
Merged
rust-bors[bot] merged 1 commit intoSep 17, 2026
Merged
Conversation
rustbot
added
O-windows
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @jhpratt (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
3 tasks
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 16, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 16, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
…uwer Rollup of 8 pull requests Successful merges: - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #158186 (Guarantee 8 bytes of alignment of RawWakerVTable) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162825 (core: Add examples for `debug_closure_helpers`) - #162856 (Stabilize CommandExt::show_window)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 17, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
Rollup of 12 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #158186 (Guarantee 8 bytes of alignment of RawWakerVTable) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162856 (Stabilize CommandExt::show_window)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 17, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 17, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
Rollup of 16 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 17, 2026
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
…uwer Rollup of 24 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162177 (Properly implement the gpu-kernel ABI for amdgpu) - #162411 (Make Receiver `#[rustc_dyn_incompatible_trait]`) - #162760 (yeet alias new_from_def_id) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162312 (core: Rewrite docs for try_as_dyn) - #162785 (Avoid creating overlapping assignments in MatchBranchSimplification) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window) - #162865 (Complex conjugate, negation and default) - #162874 (Add support for `annotate_snippets::snippet::AnnotationKind::Visible`) - #162881 (Simplify the macro for forwarding Decoder methods ) - #162888 (Fix a typo on the Armv7-R platform docs page)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
…uwer Rollup of 23 pull requests Successful merges: - #161596 (coretests: Add more pattern tests.) - #162411 (Make Receiver `#[rustc_dyn_incompatible_trait]`) - #162760 (yeet alias new_from_def_id) - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #162876 (Move operations out of `rustc_middle::query::job`) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #160212 (traits: Fix rigid alias liveness matching) - #160544 (Stabilize `feature(trim_prefix_suffix)` (`{str, [T], Path}::trim_prefix` and `{str, [T]}::trim_suffix`)) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162312 (core: Rewrite docs for try_as_dyn) - #162785 (Avoid creating overlapping assignments in MatchBranchSimplification) - #162805 (Add `must_use` lint to `ExitCode`) - #162825 (core: Add examples for `debug_closure_helpers`) - #162841 (enable asm tests for xtensa targets) - #162842 (reintroduce check RibKind::ConstParamTy did in direct consts) - #162845 (mgca: fix issue with mismatched array valtree/valtree tys) - #162856 (Stabilize CommandExt::show_window) - #162865 (Complex conjugate, negation and default) - #162874 (Add support for `annotate_snippets::snippet::AnnotationKind::Visible`) - #162881 (Simplify the macro for forwarding Decoder methods ) - #162888 (Fix a typo on the Armv7-R platform docs page)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 17, 2026
Rollup merge of #162856 - nodamushi:stabilize-command-ext-show-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of #127544 was completed. #127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize
std::os::windows::process::CommandExt::show_window.The final comment period of #127544 was completed.
#127544 (comment)
I have been using this function for 2 years. I want to use this function on stable Rust.
So, I open a pull request.
windows_process_extensions_show_windowfeature appears only in the location I modified.LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using
rg) and the actual editing (usingnano) myself.