Skip to content

Validate React on Rails 17 RC 9#779

Merged
justin808 merged 2 commits into
masterfrom
jg-codex/ror-17-rc9
Jul 13, 2026
Merged

Validate React on Rails 17 RC 9#779
justin808 merged 2 commits into
masterfrom
jg-codex/ror-17-rc9

Conversation

@justin808

@justin808 justin808 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Update React on Rails Pro gem/npm packages to RC9, resolving transitive OSS packages to RC9.
  • Update react-on-rails-rsc to 19.2.1-rc.1.
  • Refresh the README version targets and keep unrelated dependencies unchanged.

Validation

  • bundle check and frozen Yarn install
  • Client/server/RSC test bundle build
  • Focused RSC error-boundary regression spec: 1 example, 0 failures
  • The prior RC7 concern is resolved: Simulate Error shows the fallback and Retry restores content
  • Exact dependency/version checks and git diff --check
  • Independent codex review --commit a6199293cfcc87454052d1055a25ecb7e0e81779: clean

The external reviewer’s broad browser suite encountered local ChromeDriver/Chrome startup failures; the focused affected RSC system spec passed against an isolated RC9 renderer.

Lockfile audit

Locks changed only the requested direct Pro/RSC packages and transitive React on Rails package. No unrelated dependency, platform, native/precompiled, source-build, or build-time dependency changed.

QA Evidence

  • QA lane: codex-rc9-qa
  • Scope checked: release manifests, locks, test bundle, and prior RSC error-boundary concern
  • Tested at: a6199293cfcc87454052d1055a25ecb7e0e81779
  • Automated checks: listed above
  • Manual checks: focused system behavior covered through Capybara browser spec
  • Findings: stale README Rspack target corrected from 2.0.0-beta.7 to the installed 2.0.4
  • QA required: yes
  • QA required rationale: hard-gate RSC release-candidate update
  • QA lane status: satisfied
  • Release-blocking status: clear for affected surface
  • Process-gap disposition: not applicable

Confidence note: High for the release-stack and prior RSC regression surface; hosted CI will classify broader browser-environment behavior. Merge authority remains with maintainers.

Summary by CodeRabbit

  • Chores
    • Updated React on Rails Pro and Node Renderer release candidates to 17.0.0-rc.9.
    • Updated React on Rails RSC to 19.2.1-rc.1.
    • Bumped @rspack/core and @rspack/cli to 2.0.4.
    • Synced documented version targets in the README with the updated package versions.

@github-actions

Copy link
Copy Markdown

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

+review-app-deploy

Deploy your PR branch for testing.

+review-app-delete

Remove the review app when done.

+review-app-help

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

React on Rails Pro dependencies were bumped from RC.7 to RC.9 in the Gemfile, package manifest, and README. React on Rails RSC moved from RC.0 to RC.1, while README Rspack targets moved to 2.0.4.

Changes

Dependency version alignment

Layer / File(s) Summary
Update dependency versions
Gemfile, package.json, README.md
React on Rails Pro references move to 17.0.0.rc.9/17.0.0-rc.9, RSC references move to 19.2.1-rc.1, and README Rspack targets move to 2.0.4.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: updating React on Rails dependencies to RC 9.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/ror-17-rc9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review: Validate React on Rails 17 RC 9

Overview

Mechanical dependency bump: react_on_rails_pro (gem + npm) and react-on-rails-pro-node-renderer go from rc.7rc.9, and react-on-rails-rsc goes from rc.0rc.1. Gemfile, Gemfile.lock, package.json, yarn.lock, and the README version-targets table are all touched, no application code changes.

Consistency check

Verified all five files reference the new versions consistently, with no stale rc.7/rc.0 references left behind and no unrelated transitive dependencies bumped:

  • Gemfile / Gemfile.lock: react_on_rails_pro, react_on_rails17.0.0.rc.9
  • package.json / yarn.lock: react-on-rails-pro, react-on-rails-pro-node-renderer17.0.0-rc.9, react-on-rails-rsc19.2.1-rc.1 (transitive react-on-rails in yarn.lock also bumped) ✅
  • README.md version-targets table matches the new pins ✅

Code quality / risk

  • Scope is minimal and isolated — good practice for a version-bump PR (no unrelated changes bundled in).
  • Exact version pins (=) are kept for both the gem and npm packages, consistent with prior convention for this pre-release dependency.
  • No test files changed. Given this is purely a dependency upgrade with no source changes, that's expected — correctness here depends on the upstream RC actually fixing the issue it's meant to fix (the prior RC7 RSC error-boundary/fallback regression) and on existing specs continuing to pass against it.
  • Since react_on_rails_pro/react-on-rails-rsc are pre-release (RC) versions, standard caveat applies: pin exactly (already done) and confirm CI is green before merging, since RC releases can carry breaking changes between candidates.

Security

No security concerns — this only updates a first-party (shakacode) dependency's version pins; no new packages, no widened version ranges, no code paths altered.

Suggestions

  • None blocking. Once CI confirms the full test/browser suite passes against RC9 (the PR notes local ChromeDriver failures prevented running the broader browser suite locally), this looks safe to merge.

@greptile-apps

greptile-apps Bot commented Jul 12, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the React on Rails release-candidate stack. The main changes are:

  • react_on_rails_pro gem moved to 17.0.0.rc.9.
  • React on Rails Pro npm packages moved to 17.0.0-rc.9.
  • react-on-rails-rsc moved to 19.2.1-rc.1.
  • Lockfiles were refreshed for the requested package versions.
  • README version targets were updated for the React on Rails packages.

Confidence Score: 5/5

This looks safe to merge after the README version table is cleaned up.

  • The Ruby and JavaScript package pins line up across the manifests and lockfiles.
  • The only issue found is a stale Rspack version target in the refreshed README table.

README.md

Important Files Changed

Filename Overview
Gemfile Updates the direct react_on_rails_pro gem pin to 17.0.0.rc.9.
Gemfile.lock Resolves react_on_rails_pro and its pinned react_on_rails dependency to 17.0.0.rc.9.
package.json Updates the React on Rails Pro npm packages to 17.0.0-rc.9 and react-on-rails-rsc to 19.2.1-rc.1.
yarn.lock Refreshes the resolved entries and integrity hashes for the requested React on Rails npm packages.
README.md Updates the React on Rails version targets, but leaves the Rspack target out of sync with the manifests.

Reviews (1): Last reviewed commit: "Update React on Rails stack to rc.9" | Re-trigger Greptile

Comment thread README.md Outdated
- `react-on-rails-pro-node-renderer` npm package: `17.0.0-rc.9`
- `react-on-rails-rsc` npm package: `19.2.1-rc.1`
- `shakapacker` gem/npm package: `10.2.0`
- `@rspack/core` and `@rspack/cli`: `2.0.0-beta.7`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Rspack Target Is Stale

The refreshed version table still lists @rspack/core and @rspack/cli as 2.0.0-beta.7, but the manifests and lockfile resolve both packages at 2.0.4. A reader using this table as the release matrix can downgrade the Rspack packages and end up with a different bundler API than the checked-in install uses.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, need to address.

@claude

claude Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review: Validate React on Rails 17 RC 9

Overview

Pure dependency version bump: react_on_rails_pro (and its transitive react_on_rails dep) 17.0.0.rc.717.0.0.rc.9, react-on-rails-pro-node-renderer 17.0.0-rc.717.0.0-rc.9, and react-on-rails-rsc 19.2.1-rc.019.2.1-rc.1. README version-targets table is refreshed to match, including fixing an already-stale @rspack/core/@rspack/cli line (2.0.0-beta.72.0.4, which matches what package.json/yarn.lock already had before this PR).

Code quality / correctness

  • Version bumps are consistent across Gemfile, Gemfile.lock, package.json, and yarn.lock — no stray rc.7/rc.0 references left behind anywhere else in the tree.
  • Lockfile diffs are scoped exactly to the touched packages plus their integrity hashes; no unrelated dependency drift.
  • No source/behavioral code changes, so no new tests are expected here.

Risks / things worth double-checking before merge

  • Pre-release (RC) pins: This continues an existing pattern in the repo (it was already pinned to rc.7), so it's not a new risk introduced by this PR, but it's worth a reminder that RC gems can be yanked/republished upstream — worth confirming CI resolves these successfully rather than relying only on the local lockfile.
  • PR description mentions the external reviewer's full browser suite failed locally due to ChromeDriver/Chrome startup issues, and only a single focused RSC error-boundary spec was actually run/passed. Given the whole point of this bump is to validate an RSC error-boundary regression, I'd want to see the full Capybara/system-spec suite pass in CI (not just the one focused spec) before merging, since local browser tooling failures could be masking other regressions.
  • Minor/non-blocking: CHANGELOG.md isn't updated. The file appears loosely maintained already (sparse recent entries), so this is optional, not a blocker.

Security

No security concerns — this only bumps versions of an already-trusted private/pro dependency pulled from rubygems.org/npm with valid integrity hashes in the lockfiles.

Performance

N/A — no code paths changed, just dependency versions.

Summary: Low-risk, well-scoped version bump with consistent, complete lockfile/doc updates. Main ask before merging is to confirm the full RSC/system-spec suite passes in CI, since local browser testing was reportedly blocked and only one narrow regression spec was verified.

@justin808

Copy link
Copy Markdown
Member Author

+review-app-deploy

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

🎉 Deploy Complete!

Open Review App

Deployment successful for PR #779, commit a619929

🎮 Control Plane Console
📋 View Completed Action Build and Deploy Logs

@justin808 justin808 merged commit 0b2d0b4 into master Jul 13, 2026
6 checks passed
@justin808 justin808 deleted the jg-codex/ror-17-rc9 branch July 13, 2026 01:17
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

✅ Review App Deleted

Review app for PR #779 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant