Validate React on Rails 17 RC 9#779
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
WalkthroughReact on Rails Pro dependencies were bumped from RC.7 to RC.9 in the Gemfile, package manifest, and README. React on Rails RSC moved from RC.0 to RC.1, while README Rspack targets moved to 2.0.4. ChangesDependency version alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review: Validate React on Rails 17 RC 9OverviewMechanical dependency bump: Consistency checkVerified all five files reference the new versions consistently, with no stale
Code quality / risk
SecurityNo security concerns — this only updates a first-party (shakacode) dependency's version pins; no new packages, no widened version ranges, no code paths altered. Suggestions
|
Greptile SummaryThis PR updates the React on Rails release-candidate stack. The main changes are:
Confidence Score: 5/5This looks safe to merge after the README version table is cleaned up.
README.md Important Files Changed
Reviews (1): Last reviewed commit: "Update React on Rails stack to rc.9" | Re-trigger Greptile |
| - `react-on-rails-pro-node-renderer` npm package: `17.0.0-rc.9` | ||
| - `react-on-rails-rsc` npm package: `19.2.1-rc.1` | ||
| - `shakapacker` gem/npm package: `10.2.0` | ||
| - `@rspack/core` and `@rspack/cli`: `2.0.0-beta.7` |
There was a problem hiding this comment.
The refreshed version table still lists @rspack/core and @rspack/cli as 2.0.0-beta.7, but the manifests and lockfile resolve both packages at 2.0.4. A reader using this table as the release matrix can downgrade the Rspack packages and end up with a different bundler API than the checked-in install uses.
Review: Validate React on Rails 17 RC 9OverviewPure dependency version bump: Code quality / correctness
Risks / things worth double-checking before merge
SecurityNo security concerns — this only bumps versions of an already-trusted private/pro dependency pulled from rubygems.org/npm with valid integrity hashes in the lockfiles. PerformanceN/A — no code paths changed, just dependency versions. Summary: Low-risk, well-scoped version bump with consistent, complete lockfile/doc updates. Main ask before merging is to confirm the full RSC/system-spec suite passes in CI, since local browser testing was reportedly blocked and only one narrow regression spec was verified. |
|
+review-app-deploy |
🎉 Deploy Complete!Open Review AppDeployment successful for PR #779, commit a619929 🎮 Control Plane Console |
✅ Review App DeletedReview app for PR #779 is deleted |
Summary
react-on-rails-rscto19.2.1-rc.1.Validation
bundle checkand frozen Yarn installgit diff --checkcodex review --commit a6199293cfcc87454052d1055a25ecb7e0e81779: cleanThe external reviewer’s broad browser suite encountered local ChromeDriver/Chrome startup failures; the focused affected RSC system spec passed against an isolated RC9 renderer.
Lockfile audit
Locks changed only the requested direct Pro/RSC packages and transitive React on Rails package. No unrelated dependency, platform, native/precompiled, source-build, or build-time dependency changed.
QA Evidence
codex-rc9-qaa6199293cfcc87454052d1055a25ecb7e0e817792.0.0-beta.7to the installed2.0.4Confidence note: High for the release-stack and prior RSC regression surface; hosted CI will classify broader browser-environment behavior. Merge authority remains with maintainers.
Summary by CodeRabbit
@rspack/coreand@rspack/clito 2.0.4.