Skip to content

Validate React on Rails 17 RC10#782

Merged
justin808 merged 1 commit into
masterfrom
jg-codex/ror-17-rc10
Jul 14, 2026
Merged

Validate React on Rails 17 RC10#782
justin808 merged 1 commit into
masterfrom
jg-codex/ror-17-rc10

Conversation

@justin808

@justin808 justin808 commented Jul 14, 2026

Copy link
Copy Markdown
Member

Why

Validate the published React on Rails 17 RC10 artifacts in the tutorial after the SSR renderer URL-global prerequisite was merged in #781.

Changes

  • Pin react_on_rails and react_on_rails_pro to 17.0.0.rc.10.
  • Pin react-on-rails, react-on-rails-pro, and react-on-rails-pro-node-renderer to 17.0.0-rc.10.
  • Regenerate the committed Bundler and Yarn locks with the repository's declared package managers.

Only Gemfile, Gemfile.lock, package.json, and yarn.lock change.

Verification

  • Frozen Bundler and Yarn installs
  • .agents/bin/build
  • Fresh-renderer focused SSR regression: 3 examples, 0 failures
  • Full CI: RENDERER_PORT=3820 .agents/bin/test
  • Fresh-renderer HTTP smoke for the root SSR route and the server-components shell
  • The final branch tree is byte-identical to the independently audited local combined candidate 11db78c6caee63bdcf96253aa1bd028038508f3e.

No RC10 regression was observed.

Summary by CodeRabbit

  • Chores
    • Updated React on Rails Pro components to release candidate 17.0.0-rc.10.
    • Synchronized the Ruby and JavaScript package versions for improved compatibility.

@github-actions

Copy link
Copy Markdown

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

+review-app-deploy

Deploy your PR branch for testing.

+review-app-delete

Remove the review app when done.

+review-app-help

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2851c3dd-ab80-4ec6-a1d7-aea0aed92f26

📥 Commits

Reviewing files that changed from the base of the PR and between 92ae507 and 2b567f1.

⛔ Files ignored due to path filters (2)
  • Gemfile.lock is excluded by !**/*.lock
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • Gemfile
  • package.json

Walkthrough

React on Rails Pro dependencies were updated from release candidate 9 to release candidate 10 in the Ruby and npm manifests.

Changes

React on Rails Pro dependency update

Layer / File(s) Summary
Update React on Rails Pro versions
Gemfile, package.json
The react_on_rails_pro, react-on-rails-pro, and react-on-rails-pro-node-renderer dependencies were updated from RC.9 to RC.10.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: ihabadham

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: validating React on Rails 17 RC10.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/ror-17-rc10

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:8)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review: Validate React on Rails 17 RC10

Overview

Minimal, mechanical version bump: react_on_rails_pro (Gemfile/Gemfile.lock) and react-on-rails-pro / react-on-rails-pro-node-renderer (package.json/yarn.lock) go from 17.0.0.rc.917.0.0.rc.10. Transitive react_on_rails / react-on-rails pins update correctly in both lockfiles as a result. Scope is exactly the 4 files mentioned in the PR description — no incidental drift.

Code quality / correctness

  • ✅ Version bumps are internally consistent: Gemfile.lock's react_on_rails (17.0.0.rc.10) and the react_on_rails_pro dependency constraint react_on_rails (= 17.0.0.rc.10) match; same pattern holds in yarn.lock for the npm packages.
  • ✅ No direct react_on_rails/react-on-rails entries were left stale in Gemfile/package.json — confirmed those aren't direct deps, so nothing was missed there.
  • ✅ Diff is exactly what the PR description claims: only Gemfile, Gemfile.lock, package.json, yarn.lock changed, no unrelated lockfile churn visible in the diff.

Security considerations

  • Bumping to a release-candidate version (rc.10) rather than a stable release — expected here since this is explicitly a pre-release validation PR per the description, but worth confirming this doesn't accidentally ship to a production branch before RoR 17 is GA.
  • Integrity hashes in yarn.lock were regenerated for the new tarballs (new sha512 values) — consistent with a legitimate yarn install against the real registry rather than a hand edit.

Test coverage

  • PR description states frozen Bundler/Yarn installs, .agents/bin/build, SSR regression (3 examples), full CI via .agents/bin/test, and an HTTP smoke test were run. That's solid verification for a dependency-only bump; no additional test coverage is needed for this change since it touches no application code.

Risk

Low risk — this is a pure dependency pin update with no code changes. Main residual risk is inherent to tracking an upstream RC (rc.10 could still have its own bugs), not to this PR's mechanics.

No blocking issues found.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR validates the React on Rails RC10 package set in the tutorial app. The main changes are:

  • Ruby react_on_rails_pro pinned to 17.0.0.rc.10.
  • Bundler lockfile regenerated for react_on_rails and react_on_rails_pro RC10.
  • JavaScript React on Rails Pro packages pinned to 17.0.0-rc.10.
  • Yarn lockfile regenerated for the matching RC10 npm packages.

Confidence Score: 5/5

This looks safe to merge after confirming the renderer package still exposes the startup API used by the app.

  • The Ruby and JavaScript React on Rails package family stays aligned on RC10.
  • The only follow-up is a conditional package-export compatibility check for the SSR renderer startup path.

package.json

Important Files Changed

Filename Overview
Gemfile Updates the react_on_rails_pro Ruby gem pin from RC9 to RC10.
Gemfile.lock Regenerates the locked Ruby package versions for react_on_rails and react_on_rails_pro at RC10.
package.json Updates the React on Rails Pro npm package pins to RC10; the renderer startup export should stay compatible.
yarn.lock Regenerates Yarn entries for the RC10 React on Rails npm packages.

Reviews (1): Last reviewed commit: "chore: validate React on Rails 17 RC10" | Re-trigger Greptile

Comment thread package.json
@justin808

Copy link
Copy Markdown
Member Author

Address-review summary

Scan scope: full review history through 2026-07-14T07:48:11Z.

Mattered

  • None.

Skipped

  • Greptile's renderer-export concern was verified against exact head 2b567f1c57f28288724958ae0d2999656a653c27. Focused SSR, full CI, and HTTP SSR/RSC smoke evidence proves the RC10 named CommonJS export starts successfully; no code change was needed. The evidence reply was posted and the thread resolved.

Deferred-work tracking: none.

Next default scan starts after this comment. Say check all reviews to rescan the full PR.

@justin808 justin808 merged commit a28acce into master Jul 14, 2026
18 checks passed
@justin808 justin808 deleted the jg-codex/ror-17-rc10 branch July 14, 2026 07:58
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

✅ Review App Deleted

Review app for PR #782 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant