Skip to content

Adding SZ HDF5 filter - #203

Closed
orioltinto wants to merge 14 commits into
silx-kit:mainfrom
orioltinto:main
Closed

orioltinto wants to merge 14 commits into
silx-kit:mainfrom
orioltinto:main

Conversation

@orioltinto

Copy link
Copy Markdown

Right now the filter works in Ubuntu but haven't tried anywhere else.

The implementation seems clean enough to me except for the workaround that I had to do for running the configure script:

            if lib_name == "sz":
                from pathlib import Path
                # Execute configure script
                configure_path = Path().cwd() / "src" / "SZ" / "configure"
                self.spawn([configure_path.as_posix()])
                # Move config.h from the current working directory to SZ directory.
                config_h_path = Path().cwd() / "config.h"
                config_h_path.rename(configure_path.parent / "config.h")

If anybody finds a better solution it would be great, otherwise this works.

@vasole

vasole commented Nov 10, 2022

Copy link
Copy Markdown
Member

To give a chance of having something running under windows, I would certainly prefer to use cmake rather than configure.

At least it is what I have used to generate config.h

@vasole vasole mentioned this pull request Nov 22, 2022
@vasole vasole closed this Nov 22, 2022
@vasole

vasole commented Nov 22, 2022

Copy link
Copy Markdown
Member

Your changes approved. Work continues on #206

@t20100 t20100 added this to the 4.0.0 milestone Nov 28, 2022
t20100 added a commit to t20100/hdf5plugin that referenced this pull request Sep 16, 2025
6af9287fb Release 1.2.2
de19405e5 Merge pull request silx-kit#203 from haney/msvc_shared
4dd78f2de Export symbols from snappy_test_support when building shared
b395cf7a4 Merge pull request silx-kit#197 from rp42/main
fa07e8a94 Fix data corruption when output of snappy compression is more than 4GB
49087d4e1 Merge pull request silx-kit#200 from gruenich/feature/cmake-3.10
a688be4b7 [cmake] Require CMake version 3.10 or newer
a6b9f87f8 Support clang-cl on Windows
32ded457c Update CMakeLists NEON flag to reflect only AArch64 NEON optimizations
fcf1982ac Update bazel module
58d911b28 Add missing functional include for std::less_equal
b49982cc1 Merge pull request silx-kit#179 from mmorel-35/bzlmod
07406b938 Merge pull request silx-kit#181 from AtomicRobotMan0101/main
dc3577f5b Update README.md
09d30d36f chore(bazel): add MODULE.bazel files for bzlmod

git-subtree-dir: lib/snappy
git-subtree-split: 6af9287fbdb913f0794d0148c6aa43b58e63c8e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants