Repository navigation
Adding SZ HDF5 filter - #203
Closed
orioltinto wants to merge 14 commits into
Closed
orioltinto wants to merge 14 commits into
orioltinto wants to merge 14 commits into
Conversation
git-subtree-dir: src/SZ git-subtree-split: 5857c6ed1f7a8ca1c2822a88e2f614e466dc4d34
"Working" version of SZ without using CMake
# Conflicts: # setup.py
Member
|
To give a chance of having something running under windows, I would certainly prefer to use cmake rather than configure. At least it is what I have used to generate config.h |
Merged
Member
|
Your changes approved. Work continues on #206 |
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Sep 16, 2025
6af9287fb Release 1.2.2 de19405e5 Merge pull request silx-kit#203 from haney/msvc_shared 4dd78f2de Export symbols from snappy_test_support when building shared b395cf7a4 Merge pull request silx-kit#197 from rp42/main fa07e8a94 Fix data corruption when output of snappy compression is more than 4GB 49087d4e1 Merge pull request silx-kit#200 from gruenich/feature/cmake-3.10 a688be4b7 [cmake] Require CMake version 3.10 or newer a6b9f87f8 Support clang-cl on Windows 32ded457c Update CMakeLists NEON flag to reflect only AArch64 NEON optimizations fcf1982ac Update bazel module 58d911b28 Add missing functional include for std::less_equal b49982cc1 Merge pull request silx-kit#179 from mmorel-35/bzlmod 07406b938 Merge pull request silx-kit#181 from AtomicRobotMan0101/main dc3577f5b Update README.md 09d30d36f chore(bazel): add MODULE.bazel files for bzlmod git-subtree-dir: lib/snappy git-subtree-split: 6af9287fbdb913f0794d0148c6aa43b58e63c8e3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the filter works in Ubuntu but haven't tried anywhere else.
The implementation seems clean enough to me except for the workaround that I had to do for running the configure script:
If anybody finds a better solution it would be great, otherwise this works.