Repository navigation
Conversation
git-subtree-dir: src/SZ git-subtree-split: 5857c6ed1f7a8ca1c2822a88e2f614e466dc4d34
"Working" version of SZ without using CMake
# Conflicts: # setup.py
Closed
Member
Author
|
At this point, the code compiles under all the platforms and the test file supplied by @orioltinto is properly read. Still missing tests. |
…allclose function.
Add SZ: Docstrings, self-explanatory arguments and default value.
t20100
reviewed
Nov 23, 2022
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
t20100
reviewed
Nov 23, 2022
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
t20100
reviewed
Nov 23, 2022
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
t20100
reviewed
Nov 23, 2022
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
t20100
reviewed
Nov 23, 2022
t20100
approved these changes
Nov 23, 2022
t20100
left a comment
t20100
left a comment
Member
There was a problem hiding this comment.
LGTM, I left a few suggestions.
There is probably a few things to change in setup.py but that can be done in another PR.
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
This was referenced Nov 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include and completes #203