Repository navigation
ci: rebuild the api image when the GeoIP download script changes - #20
Merged
Merged
Conversation
The api Dockerfile copies scripts/download-geoip-database.sh, but the image path filter did not list it, so a change to it never rebuilt the image.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
BryanLawless
added a commit
that referenced
this pull request
Nov 5, 2026
Pull requests are now squash-merged directly into main; dev, its workflow, sync-dev and the dev ruleset are retired. Pushes to main run CI, publish the changed images and run release-please, and Flux image automation pins digests on main. Also brings in the changes merged into dev since the last promotion: - feat(deploy): manage operator secrets in the OpenBao web UI (#14) - feat(deploy): add dynamic DNS, a host firewall and read-only database access (#15) - chore: remove the docs folder (#16) - chore: remove dead code, configuration and unused runtime options (#17) - fix(api): restore the executable bit on the GeoIP download script (#19) - ci: rebuild the api image when the GeoIP download script changes (#20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api Dockerfile copies scripts/download-geoip-database.sh into the image, but the api entry in .github/filters/images.yml did not list it, so changing the script never rebuilt the image (as with #19). Merging this also rebuilds all five images, since every app's filter includes the filter file; that republishes the images whose builds were cancelled when #17's api build failed.