Repository navigation
chore: remove dead code, configuration and unused runtime options - #17
Merged
Merged
Conversation
- Chart CI values use the build-<sha>-<timestamp> tags production uses instead of the retired main-<sha> scheme. - Drop the unused tsx and tsconfig-paths-webpack-plugin dependencies (and the tsx shebang on a file node runs), pnpm overrides and build allowances for packages that are no longer installed, and @parcel/watcher from the marketing image rebuild. - Remove the unused environment namespace name and EnvironmentVariableName type, generateRandomString, scaledIntegerToMoney, mapWithConcurrency and StripeDisputeStatus. - Remove stale Biome exceptions and ignores, the .dockerignore whitelist for a binary nothing builds, the devcontainer's unused 5173 port and GHCR label, VS Code excludes and gitignore entries for paths that no longer exist, and .moon/docker references.
…forks snapflowd builds the runtime without options, so WithVolumeBlockStore and WithGPUManager were never applied; the runtime always uses the local block store and the detected host GPUs. Forking from a named standby snapshot record was never wired up (ForkRequest.SnapshotID was never set), so CreateStandbyWithID, KindStandby, the VM payload copy and the fork record branches are removed; pausing to standby and forking a standby instance are unchanged. Also remove the uncalled GetPort, RequiresHostEmulation, ReadLockMany and OpenedStreams.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
The Nest CLI requires it when compiling with rspack, though no source file imports it.
This was referenced Nov 5, 2026
BryanLawless
added a commit
that referenced
this pull request
Nov 5, 2026
Pull requests are now squash-merged directly into main; dev, its workflow, sync-dev and the dev ruleset are retired. Pushes to main run CI, publish the changed images and run release-please, and Flux image automation pins digests on main. Also brings in the changes merged into dev since the last promotion: - feat(deploy): manage operator secrets in the OpenBao web UI (#14) - feat(deploy): add dynamic DNS, a host firewall and read-only database access (#15) - chore: remove the docs folder (#16) - chore: remove dead code, configuration and unused runtime options (#17) - fix(api): restore the executable bit on the GeoIP download script (#19) - ci: rebuild the api image when the GeoIP download script changes (#20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes code, configuration and dependencies that nothing uses. Each item was confirmed unreferenced across the repository first.
Configuration and dependencies
build-<sha>-<timestamp>tags, matching production, instead of the retiredmain-<sha>scheme.tsx(its only use was a shebang on a filenoderuns); removes pnpm overrides and build allowances for packages no longer installed, and@parcel/watcherfrom the marketing image rebuild. The lockfile is regenerated with pnpm 11.17.0; the peer-dependency report is unchanged..dockerignorewhitelist for a binary nothing builds, the devcontainer's unused port 5173 and GHCR label, VS Code excludes and gitignore entries for paths that no longer exist, and.moon/dockerreferences.API
nameandEnvironmentVariableNametype, andgenerateRandomString,scaledIntegerToMoney,mapWithConcurrencyandStripeDisputeStatus. The variable descriptions stay: they are the only explanation of each environment variable.microVM runtime
WithVolumeBlockStoreandWithGPUManagerwere never applied; GPU passthrough (whole IOMMU group to vfio-pci, reset, health check, VRAM scrub, quarantine) and volumes always used the built-in defaults, which is unchanged.ForkRequest.SnapshotIDwas never set):CreateStandbyWithID,KindStandby, the VM payload copy and the fork record branches are removed. Pausing to standby, restoring and forking a standby instance are unchanged.GetPort,RequiresHostEmulation,ReadLockManyandOpenedStreams.Testing
tsc --noEmit, Biome on every changed file, all 831 tests pass, and the production build succeeds.gofmt,go buildandgo vetare clean in libs/microvm-go, apps/snapflow and apps/edge; the touched packages' tests pass (locally, tests that needmkfs.erofsare skipped by its absence; CI installs it).deploy/scripts/validate.shpasses with the updated chart CI values.