Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

fix: no knobs after select - #60

Merged
nekitk merged 3 commits into
storybook-eol:masterfrom
nekitk:fix-select-order
Oct 24, 2019
Merged

nekitk merged 3 commits into
storybook-eol:masterfrom
nekitk:fix-select-order

Conversation

@nekitk

@nekitk nekitk commented Aug 13, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #59
Fixes #30

  • Storybook fails to render next knobs when you pass to select options object with an empty key. Replaced empty key with --
  • Choosing empty option was setting prop value to -- which is undesired (because it is truthy). We can't set it to undefined for now (addon-knobs select should be able to have undefined options. storybookjs/storybook#4487), so I replaced it with null
  • Empty option in select was available even for required props. Changed it so it is added only for props that are not required.

@sami616

sami616 commented Aug 14, 2019

Copy link
Copy Markdown

This would be a great addition. As a work around I am passing an empty string as the default value.

@RoyalHunt

Copy link
Copy Markdown

Waiting this pr for a while. Any progress?

@vercel
vercel Bot requested a deployment to staging October 19, 2019 10:36 Abandoned
@vercel

vercel Bot commented Oct 19, 2019 •

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@vercel
vercel Bot requested a deployment to staging October 24, 2019 12:51 Abandoned
@vercel

vercel Bot commented Oct 24, 2019

Copy link
Copy Markdown

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

* upgraded storybook to support undefined in select
@vercel
vercel Bot requested a deployment to staging October 24, 2019 12:57 Abandoned
@vercel

vercel Bot commented Oct 24, 2019

Copy link
Copy Markdown

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@nekitk
nekitk merged commit bd18398 into storybook-eol:master Oct 24, 2019

This branch had an error being deployed

1 abandoned deployment
staging — 1fc39dad Deployed Oct 24, 2019 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Knobs which comes after select disappear oneOf smart knob returns "--" as value of empty option

4 participants