Repository navigation
Fix compiler crash when reporting a call to an abstract shader method - #3413
Merged
Merged
Conversation
When a method is abstract, ShaderMixer erases its whole function body (including its OpFunction/OpName), removing its entry from context.Names. The member-access resolution code later detected calls to abstract methods and tried to build the error message using context.Names[functionId], which threw KeyNotFoundException instead of producing the intended InvalidOperationException, crashing the compiler. Use methodGroupEntry.Name instead, which is captured when the method is first registered (before the abstract method body is erased) and is never removed. Applied the same fix to two other nearby error messages in the same code path that had the identical latent issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Fixes a
KeyNotFoundExceptioncrash inShaderMixerwhen a shader calls an abstract method.Abstract methods have their whole function body (including
OpName) erased before the call-site check runs, socontext.Names[functionId]throws instead of raising the intendedInvalidOperationException. Now usesmethodGroupEntry.Name, which is captured earlier and never erased.Related Issue
Types of changes
Checklist