Skip to content

Fix compiler crash when reporting a call to an abstract shader method #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xen2 merged 1 commit into from
Sep 10, 2026
Merged

Fix compiler crash when reporting a call to an abstract shader method #3413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sources/shaders/Stride.Shaders.Compilers/SDSL/ShaderMixer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ private static void ProcessMemberAccessAndForeach(MixinGlobalContext globalConte
// We currently do not allow calling base stage method from a non-stage method
// (if we were to allow them later, we would need to tweak following detection code as ShaderIndex comparison is only valid for items within the same MixinNode)
if (foundInStage)
throw new InvalidOperationException($"Method {context.Names[functionId]} was found but a base call can't be performed on a stage method from a non-stage method");
throw new InvalidOperationException($"Method {methodGroupEntry.Name} was found but a base call can't be performed on a stage method from a non-stage method");

// Is it a base call? if yes, find the direct parent
// Let's find the method in same group just before ours
Expand All @@ -1045,11 +1045,11 @@ private static void ProcessMemberAccessAndForeach(MixinGlobalContext globalConte
}

if (!baseMethodFound)
throw new InvalidOperationException($"Can't find a base method for {context.Names[functionId]}");
throw new InvalidOperationException($"Can't find a base method for {methodGroupEntry.Name}");
}

if ((selectedMethod.Flags & FunctionFlagsMask.Abstract) != 0)
throw new InvalidOperationException($"Trying to call an abstract method {selectedMethod.Shader.ShaderName}.{context.Names[functionId]}");
throw new InvalidOperationException($"Trying to call an abstract method {selectedMethod.Shader.ShaderName}.{methodGroupEntry.Name}");
functionId = selectedMethod.MethodId;

memberAccesses.Add(memberAccess.ResultId, functionId);
Expand Down