Repository navigation
Conversation
|
@claude review |
|
Claude finished @gogoout's task in 2m 11s —— View job Review of flexoki / flexoki-light themes
Verification limitation: this sandbox required approval for every non-trivial shell command ( OverallClean, well-scoped addition that follows the established seed/derive pattern exactly (compare
Minor observations (non-blocking)
Nothing else jumped out as incorrect. The contrast/chroma deltas described in the seed comments (e.g. red 4.42:1 → lifted, green 4.39:1 → darkened, yellow 3.39:1 → darkened) are internally consistent with the direction |
6dc6276 to
947a77c
Compare
* [fix] tui: themes take their stock editor colours The themes felt off beside the stock ones they are named after. An audit against each theme's official VS Code port found the seeds mostly fine and three other causes, all fixed here. - One Dark painted its code with One Half Dark (text #DCDFE4) and Monokai with MonokaiExtended (ground #222222). They now use TwoDark and MonokaiExtendedOrigin, whose ground and text are the stock ones. - derive() read only the syntax theme's ground and text. It now takes the theme's own selection, line numbers and comment colour, each only where it clears the bar the legibility tests hold that field to, with the mix as the fallback. The cursor row stays the stronger end of a selection: no shipped theme's line highlight is stronger than its selection, so the cursor row is the selection one step further from the ground. - The remaining fractions are fitted to the ports: word emphasis 0.58 -> 0.80, and the status bar a shade towards black instead of towards the text. The line-number fallback is 0.46, the quietest that passes 3:1. ADR 0039 amends ADR 0024. Two tests hold the new rules. The theme screenshots are regenerated. Closes #157 * [fix] tui: derive keeps its doc comment, and noise is held to its own colour Review follow-up. `derive()`'s doc comment sat above `const WHITE`, and then above the new `SEEN` too, so rustdoc gave it to a constant. It now sits directly on `derive`, updated for the theme's own colours. `a_theme_keeps_its_own_colours_where_they_pass` checked the selection and the line numbers but not the noise tier, which takes the comment colour on the same terms. It checks all three now.
947a77c to
0fb89fd
Compare
Classic Monokai, matched to its stock olive ground, reads as green: every grey mixed from that ground takes the olive, and the yellow-green addition tint sits right beside it. The `monokai` theme now wears Monokai Pro's warm-grey palette instead, under the same name, so existing configs keep working. Classic Monokai is no longer shipped. two-face does not ship Monokai Pro, so a seed's syntax theme is now a `Syntax`: a two-face name as before, or a `.tmTheme` compiled into the crate and parsed by syntect. `monokai.tmTheme` is written here from Monokai Pro's published palette values alone; no official or ported theme file is copied, and the crate is not affiliated with Monokai Pro (ADR 0040). Its blue is lifted to clear the chroma floor, as Dracula's cyan was, and its orange is the search fill so the fill and the skim tier are two colours.
Review follow-up. derive() takes the search fill from the seed, so the file's findHighlight is inert, but it said yellow where the seed says orange. They agree now.
Steph Ango's Flexoki, dark and light. two-face does not ship it, so both syntax themes are bundled .tmTheme files (ADR 0040), written here from Flexoki's published palette (MIT) and generated from one table so the scope mapping is the same in both. The seeds take Flexoki's 400 accents on the dark ground and its 600 accents on paper. Five inks moved to clear the legibility tests, each with the number that forced it in the seed file: the dark red and blue are lifted, and the light green and yellow are darkened. The light green also turns 4 degrees towards green, because the reviewed mark derived from it cannot reach the chroma floor in Flexoki's own hue at that lightness.
Review follow-up, as for monokai.tmTheme: the inert findHighlight key now names the colour each seed actually fills a search hit with.
0fb89fd to
a91e246
Compare
|
Replacement: #180. |
Stacked on #176, which is stacked on #175. Retarget this PR to
mainbefore merging it, after #176 is merged. A squash merge into the Monokai branch would strand it there.What changes
flexokiandflexoki-light, Steph Ango's Flexoki (MIT). There are now thirteen themes..tmThemefiles, the mechanism from ADR 0040. They are written here from Flexoki's published palette and generated from one table, so both use the same token colours. Both credit Flexoki in their headers.#100F0F), and its 600 accents on paper (#FFFCF0).#D14D41(4.42:1) and the blue#4385BEare lifted, with hue kept. The blue fell to 2.81:1 when muted for a foreign hunk.#66800B(4.39:1) and the yellow#AD8301(3.39:1) are darkened.Docs
docs/cli.md,spec/tui.mdandspec/consumers.md.assets/themes.shrecords them.assets/themes/flexoki.pngandflexoki-light.pngare new.Tests
cargo test,clippy -D warningsandfmtare clean.Gkey now lands onflexoki-light.