Repository navigation
[feat] tui: monokai wears Monokai Pro's palette - #179
Merged
Merged
Conversation
Classic Monokai, matched to its stock olive ground, reads as green: every grey mixed from that ground takes the olive, and the yellow-green addition tint sits right beside it. The `monokai` theme now wears Monokai Pro's warm-grey palette instead, under the same name, so existing configs keep working. Classic Monokai is no longer shipped. two-face does not ship Monokai Pro, so a seed's syntax theme is now a `Syntax`: a two-face name as before, or a `.tmTheme` compiled into the crate and parsed by syntect. `monokai.tmTheme` is written here from Monokai Pro's published palette values alone; no official or ported theme file is copied, and the crate is not affiliated with Monokai Pro (ADR 0040). Its blue is lifted to clear the chroma floor, as Dracula's cyan was, and its orange is the search fill so the fill and the skim tier are two colours.
Review follow-up. derive() takes the search fill from the seed, so the file's findHighlight is inert, but it said yellow where the seed says orange. They agree now.
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates #176, which was squash-merged into
fix/157-stock-palettesinstead ofmain. The content is identical to what #176 merged. #176 has the review thread.Why
After #175, classic Monokai sits on its stock olive ground
#272822. Every grey mixed from that ground takes the olive too, and the yellow-green addition tint is close to its hue. So a screen of additions reads as green. Themonokaitheme now wears Monokai Pro's warm-grey palette instead.What changes
monokaiis Monokai Pro. The config name stays the same, so existingtheme = "monokai"configs keep working. Classic Monokai is no longer shipped. A reader onmonokaiwill see a different palette after upgrading.Seed::syntaxis now aSyntax:Embedded(a two-face name, as before) orBundled(a.tmThemecompiled in withinclude_bytes!and parsed by syntect'sThemeSet::load_from_reader). Nothing is loaded at run time. two-face does not ship Monokai Pro, which is why this is needed (ADR 0040).monokai.tmThemeis written for this crate. It uses Monokai Pro's published palette values only. No official or ported theme file is copied, and the docs say the crate is not affiliated with Monokai Pro. The scope mapping is our own.#78DCE8to#6CD9E8, which clears the chroma floor, as Dracula's cyan was lifted.#FC9867is the search fill, so the fill and the yellow skim tier are two different colours.#939293are used.#727072is under 3:1 on the ground, so the noise tier uses the mix.Tests
cargo test,clippy -D warningsandfmtare clean.every_named_theme_buildsparses the bundled file, and the legibility, chroma, distinctness and own-colour tests all run over it..tmThemeis included in thecargo packagefile list.assets/themes/monokai.pngis regenerated.