Repository navigation
pr-set: pin CUDA IQ1_M MMQ (#304) - #305
Open
danielhanchen wants to merge 1 commit into
Open
danielhanchen wants to merge 1 commit into
danielhanchen wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins #304 (CUDA: add IQ1_M to MMQ) at 64b2a7e. Nothing upstream broke; this adds a feature. IQ1_M had no MMQ kernel, so batched IQ1_M matmuls (prompt processing, and MoE MUL_MAT_ID in particular) fell back to dequantize + cuBLAS. No equivalent PR is open on ggml-org/llama.cpp.
pr-set.json: CUDA: add IQ1_M to MMQ #304 appended after model : DeepSeek-V4.1-Flash-1017 full stack pin (all DeepSeek-V4.1 PRs except #292) #298.feature-checks.json: newiq1m-mmqfeature owned by CUDA: add IQ1_M to MMQ #304. It runs the IQ1_M MUL_MAT cases with m = 129 and the MUL_MAT_ID cases with 256/512 experts that CUDA: add IQ1_M to MMQ #304 adds. Both filters match 0 cases on a tree without the pin, so the check fails if the pin is missing.Evidence
llama_pinset.py simwith this pin set:The b11760+ refusal is ggml-org#25731 (Inkling) and is the same on the current master pin set without this change; #304 merges cleanly there too.
llama_pinset.py verify --cudaon b11756 and b11759 (B200):iq1m-mmqcheck, --gpuaudit --pr-set: #304 ok (basebase/upstream-d80619397, GitHub diff == the pin's own change, +256/-2 in 16 files); feature-checks coverage ok. The FIX rows for #264, #266 and #298 are the same on the current master pin set.Kernel correctness, KLD vs the CPU backend and the llama-bench numbers (about 3x prompt processing on an IQ1_M MoE, decode unchanged) are in #304.
Not covered