Repository navigation
pr-set: repin #298, #264, #266 and Inkling; pin #311 (Beam), #304 (IQ1_M MMQ) and #314 (Flint) - #312
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--fitmeasure the DSpark draft model. Before it,--fitsized the target as if it ran alone, and the draft then failedcudaMalloc.<|constrain|>header variants in the harmony-xml parser). It has no feature surface of its own;test-chatcovers it, so it is listed underuncheckedinfeature-checks.json.iq1m-mmqfeature check owned by CUDA: add IQ1_M to MMQ #304 (the IQ1_M MUL_MAT cases with m = 129 and the MUL_MAT_ID cases with 256/512 experts that CUDA: add IQ1_M to MMQ #304 adds; both match 0 cases on a tree without the pin). This supersedes pr-set: pin CUDA IQ1_M MMQ (#304) #305.archfeature check forflintowned by Model arch: Flint #314. Model arch: Flint #314 numbers the Flint pre-tokenizer 63 so it does not collide with Inkling's 62.Fix merge conflicts.Evidence
llama_pinset.pywith this pr-set and Inkling at e1b89cf:audit: 21/22 pins clean. The remaining row is model : DeepSeek-V4.1-Flash-1017 full stack pin (all DeepSeek-V4.1 PRs except #292) #298, whose basedsv41-pin-base61bcarries the earlier DeepSeek-V4.1 stack; this is unchanged from master.test-chaton b11785 fails with the old parser and passes with chat : end Beam analysis on <|constrain|> header variants #311.simon b11786 merges all 23 pins (Model arch: Flint #314 additive),pin_contractintact,merge_checksclean. CUDA verify on b11796 and the Inkling numeric gate (old head vs e1b89cf vs e1b89cf + master) were still running at merge time.Running now:
verify --cudaon b11785 (full CUDA build, test-backend-ops, test-chat, feature matrix includingiq1m-mmq). ROCm, Vulkan, macOS, Windows and ARM legs run only in the nightly.