fix(cli): add "lib" to builtin commands#174
Merged
Merged
Conversation
Member
Author
fengmk2
marked this pull request as ready for review
September 21, 2025 12:56
fengmk2
force-pushed
the
09-21-refactor_cli_add_resolve_helper
branch
from
September 21, 2025 14:56
49ae39d to
b07e3fb
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
2 times, most recently
from
September 21, 2025 14:57
52ecc1f to
9c148ab
Compare
fengmk2
force-pushed
the
09-21-refactor_cli_add_resolve_helper
branch
from
September 21, 2025 14:57
b07e3fb to
a2d6fd5
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 21, 2025 15:00
9c148ab to
45db84b
Compare
fengmk2
force-pushed
the
09-21-refactor_cli_add_resolve_helper
branch
2 times, most recently
from
September 22, 2025 01:13
24d7cac to
bb8c75a
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 22, 2025 01:13
45db84b to
e569935
Compare
fengmk2
force-pushed
the
09-21-refactor_cli_add_resolve_helper
branch
2 times, most recently
from
September 22, 2025 01:38
92f8ff4 to
cb238c4
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 22, 2025 01:38
e569935 to
b82700f
Compare
fengmk2
changed the base branch from
09-21-refactor_cli_add_resolve_helper
to
graphite-base/174
September 22, 2025 01:58
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 22, 2025 01:58
b82700f to
24b2f36
Compare
fengmk2
force-pushed
the
graphite-base/174
branch
from
September 22, 2025 01:58
cb238c4 to
b412f6e
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 22, 2025 01:59
24b2f36 to
e042d94
Compare
fengmk2
force-pushed
the
09-21-fix_cli_add_missing_lib_command
branch
from
September 22, 2025 02:54
e042d94 to
3e7a55b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds "lib" to the list of builtin CLI commands to ensure consistency between the available commands and the internal command handling logic.
- Adds "lib" to the BUILTIN_COMMANDS array
- Adds "lib" command parsing logic in the argument parser
- Updates snapshot test to reflect a minor documentation text change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/binding/src/lib.rs | Adds "lib" to builtin commands list and command parsing logic |
| packages/global/snap-tests/cli-helper-message/snap.txt | Updates snapshot test with minor grammar fix in doc command description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Sep 22, 2025
wan9chi
approved these changes
Sep 22, 2025
Member
Author
This was referenced Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It can still run without adding this logic